Skip to content

Brings back upstream search widget on Android #29416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Brings back upstream search widget on Android #29416

merged 1 commit into from
Jun 5, 2025

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#46597
That's a revert of #28753

@SergeyZhukovsky SergeyZhukovsky self-assigned this Jun 5, 2025
@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Jun 5, 2025
@SergeyZhukovsky SergeyZhukovsky requested a review from a team as a code owner June 5, 2025 17:07
@SergeyZhukovsky SergeyZhukovsky added the CI/skip-macos-arm64 Do not run CI builds for macOS arm64 label Jun 5, 2025
@SergeyZhukovsky SergeyZhukovsky requested review from a team as code owners June 5, 2025 17:07
samartnik
samartnik approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brave-builds
Copy link
Collaborator

Warning

You have got a presubmit warning. Please address it if possible.

It looks like you are trying to commit some images. If these are non-test-only images, please make sure to read and apply the tips in https://chromium.googlesource.com/chromium/src/+/HEAD/docs/speed/binary_size/optimization_advice.md#optimizing-images
This check is FYI only and will not block your CL on the CQ.

Items:

android/java/res/drawable-night-nodpi/widget_preview.png
android/java/res/drawable-nodpi/widget_preview.png

@SergeyZhukovsky
Brings back upstream search widget on Android
b05547f 
This is a revert of #28753
The reason: we received a lot of feedback from frustrated users that
the widget was very useful.
Resolves: brave/brave-browser#46597
@SergeyZhukovsky SergeyZhukovsky force-pushed the android_search_widget branch from 8b46518 to b05547f Compare June 5, 2025 17:28
@SergeyZhukovsky
Copy link
Member Author

Warning

You have got a presubmit warning. Please address it if possible.

It looks like you are trying to commit some images. If these are non-test-only images, please make sure to read and apply the tips in https://chromium.googlesource.com/chromium/src/+/HEAD/docs/speed/binary_size/optimization_advice.md#optimizing-images
This check is FYI only and will not block your CL on the CQ.

Items:

android/java/res/drawable-night-nodpi/widget_preview.png
android/java/res/drawable-nodpi/widget_preview.png

we are following upstream in that case, we just replace the existing png with our

cdesouza-chromium
cdesouza-chromium approved these changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdesouza-chromium cdesouza-chromium mentioned this pull request Jun 5, 2025
Merged
24 tasks
@SergeyZhukovsky SergeyZhukovsky merged commit 7bcbc8b into master Jun 5, 2025
18 checks passed
@SergeyZhukovsky SergeyZhukovsky deleted the android_search_widget branch June 5, 2025 20:17
@github-actions github-actions bot added this to the 1.81.x - Nightly milestone Jun 5, 2025
brave-builds added a commit that referenced this pull request Jun 5, 2025
@brave-builds
Uplift of #29416 (squashed) to beta
55de623
brave-builds added a commit that referenced this pull request Jun 5, 2025
@brave-builds
Uplift of #29416 (squashed) to release
fa10298
This was referenced Jun 5, 2025
Merged
Merged
@brave-builds
Copy link
Collaborator

Released in v1.81.56

@hffvld
Copy link
Collaborator

hffvld commented Jun 6, 2025

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 16 BP31.250502.008 release-keys
Brave build: 1.81.60 
Chromium: 137.0.7151.68 (Official Build) canary (64-bit)
Fresh profile

STEPS:

  1. Fresh install and launch Brave 1.81.60
  2. Close Brave > Tap and hold on the Homescreen to add a new widget
  3. Find Brave > Verify that there are 3 widgets total, including Brave search 3 x 1
  4. Add that widget to a homescreen > Verify that it works as expected

ACTUAL RESULTS:

  • Verified that the Brave search 3 x 1 widget is shown in the list of widgets.
  • Verified that the Brave search 3 x 1 widget can be added to a homescreen and works as expected.

Galaxy Tab S8

1 2 3
1 2 3

Pixel 7

1 2 3
1 2 3
Upgraded profile

STEPS:

  1. Fresh install and launch Brave 1.81.52
  2. Attempt to add the widget to a homescreen > Confirm that there is no Brave search 3 x 1 widget available
  3. Upgrade Brave to 1.81.60
  4. Attempt to add the widget to a homescreen > Verify that there are 3 widgets total, including Brave search 3 x 1

ACTUAL RESULTS:

  • Verified that the Brave search 3 x 1 widget is shown in the list of widgets after Brave upgrade to 1.81.60
  • Verified that the Brave search 3 x 1 widget can be added to a homescreen and works as expected.
1 2
Screencast Screencast
1 2

oajara pushed a commit that referenced this pull request Jun 9, 2025
@SergeyZhukovsky @oajara
Brings back upstream search widget on Android (#29416)
709beb9 
This is a revert of #28753
The reason: we received a lot of feedback from frustrated users that
the widget was very useful.
Resolves: brave/brave-browser#46597
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@samartnik samartnik samartnik approved these changes

@cdesouza-chromium cdesouza-chromium cdesouza-chromium approved these changes

Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
1.81.x - Nightly
Development

Successfully merging this pull request may close these issues.

Bring back Search widget from upstream
6 participants
@SergeyZhukovsky @brave-builds @hffvld @AlexeyBarabash @samartnik @cdesouza-chromium