Skip to content

Revert "[iOS] Register P3A metric configuration component (#29390)" #29401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Jun 4, 2025

This reverts commit 987e638.

Registering this component causes a crash on release builds

@kylehickinson kylehickinson self-assigned this Jun 4, 2025
@kylehickinson kylehickinson requested a review from a team as a code owner June 4, 2025 20:57
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Jun 4, 2025
@kylehickinson kylehickinson enabled auto-merge (squash) June 4, 2025 20:58
@kylehickinson
Copy link
Collaborator Author

kylehickinson commented Jun 4, 2025

Likely related to brave/brave-browser#46549, will verify once we have crash reports

@kylehickinson kylehickinson merged commit 9591d23 into master Jun 4, 2025
19 checks passed
@kylehickinson kylehickinson deleted the ios-revert-p3a-metrics branch June 4, 2025 22:22
@github-actions github-actions bot added this to the 1.81.x - Nightly milestone Jun 4, 2025
@brave-builds
Copy link
Collaborator

Released in v1.81.49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants