Crash in P3AService

[SergeyZhukovsky]

There is a crash on Android and desktop that was introduced by the commit brave/brave-core@73dfa92.
https://share.backtrace.io/api/share/2Cgx2EVdZsXgyrWdNM2gKG1
https://share.backtrace.io/api/share/5RmcWQ7DWyc7Mx1B8JgmBf2

[ 00 ] p3a::P3AService::Init(scoped_refptr<network::SharedURLLoaderFactory>) ( p3a_service.cc:0 )
[ 01 ] p3a::RemoteConfigManager::SetMetricConfigs(std::__Cr::unique_ptr<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>, std::__Cr::default_delete<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>>>) ( p3a_service.cc:265 )
[ 02 ] void base::internal::ReplyAdapter<std::__Cr::unique_ptr<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>, std::__Cr::default_delete<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>>>, std::__Cr::unique_ptr<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>, std::__Cr::default_delete<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>>>>(base::OnceCallback<void (std::__Cr::unique_ptr<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>, std::__Cr::default_delete<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>>>)>, std::__Cr::unique_ptr<std::__Cr::unique_ptr<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>, std::__Cr::default_delete<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>>>, std::__Cr::default_delete<std::__Cr::unique_ptr<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>, std::__Cr::default_delete<base::flat_map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig, std::__Cr::less<void>, std::__Cr::vector<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, p3a::RemoteMetricConfig>>>>>>>>*) ( callback.h:156 )
[ 03 ] base::internal::PostTaskAndReplyRelay::RunReply(base::internal::PostTaskAndReplyRelay) ( callback.h:156 )
[ 04 ] base::internal::Invoker<base::internal::FunctorTraits<void (*&&)(base::internal::PostTaskAndReplyRelay), base::internal::PostTaskAndReplyRelay&&>, base::internal::BindState<false, true, false, void (*)(base::internal::PostTaskAndReplyRelay), base::internal::PostTaskAndReplyRelay>, void ()>::RunOnce(base::internal::BindStateBase*) ( bind_internal.h:664 )
[ 05 ] non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( callback.h:156 )
[ 06 ] base::MessagePumpAndroid::DoNonDelayedLooperWork(bool) ( message_pump_android.cc:456 )
[ 07 ] base::(anonymous namespace)::NonDelayedLooperCallback(int, int, void*) ( message_pump_android.cc:441 )

[kylehickinson]

iOS crash:

Thread 0 Crashed:
0   BraveCore                       0x000000010b63b7f8 p3a::MetricLogStore::RemoveObsoleteLogs() (in BraveCore) (metric_log_store.cc:325) + 27736056
1   BraveCore                       0x000000010b640094 p3a::MessageManager::RemoveObsoleteLogs() (in BraveCore) (message_manager.cc:142) + 27754644
2   BraveCore                       0x000000010b648324 p3a::RemoteConfigManager::SetMetricConfigs(std::__Cr::unique_ptr<...>) (in BraveCore) (remote_config_manager.cc:0) + 27788068
3   BraveCore                       0x000000010b6492c8 base::OnceCallback<void (...) && (in BraveCore) (callback.h:157) + 27792072
4   BraveCore                       0x000000010b649174 void base::internal::ReplyAdapter<...>) (in BraveCore) (post_task_and_reply_with_result_internal.h:32) + 27791732
5   BraveCore                       0x000000010ad41818 <deduplicated_symbol> (in BraveCore) + 40 + 18323480
6   BraveCore                       0x000000010ad417a8 base::internal::Invoker<base::internal::FunctorTraits<void (*&&)(base::internal::PostTaskAndReplyRelay), base::internal::PostTaskAndReplyRelay&&>, base::internal::BindState<false, true, false, void (*)(base::internal::PostTaskAndReplyRelay), base::internal::PostTaskAndReplyRelay>, void ()>::RunOnce(base::internal::BindStateBase*) (in BraveCore) (bind_internal.h:973) + 18323368
7   BraveCore                       0x000000010ad39f84 base::TaskAnnotator::RunTaskImpl(base::PendingTask&) (in BraveCore) (task_annotator.cc:209) + 18292612
8   BraveCore                       0x000000010ad3cb24 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) (in BraveCore) (thread_controller_with_message_pump_impl.cc:456) + 18303780
9   BraveCore                       0x000000010ad3c744 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() (in BraveCore) (thread_controller_with_message_pump_impl.cc:332) + 18302788
10  BraveCore                       0x000000010ad7455c base::MessagePumpCFRunLoopBase::RunWork() (in BraveCore) (message_pump_apple.mm:453) + 18531676
11  BraveCore                       0x0000000109ce60a4 base::apple::CallWithEHFrame(void () block_pointer) (in BraveCore) + 16 + 1171620
12  BraveCore                       0x000000010ad73e1c base::MessagePumpCFRunLoopBase::RunWorkSource(void*) (in BraveCore) (message_pump_apple.mm:424) + 18529820
13  CoreFoundation                  0x000000018d7b8a8c 0x18d7a9000 + 64140
14  CoreFoundation                  0x000000018d7b88a4 0x18d7a9000 + 63652
15  CoreFoundation                  0x000000018d7b8700 __CFRunLoopDoSources0 + 232 (CFRunLoop.c:2051)
16  CoreFoundation                  0x000000018d7b9080 0x18d7a9000 + 65664
17  CoreFoundation                  0x000000018d7bac3c 0x18d7a9000 + 72764
18  GraphicsServices                0x00000001da999454 GSEventRunModal + 168 (GSEvent.c:2196)
19  UIKitCore                       0x00000001901cd274 0x190098000 + 1266292
20  UIKitCore                       0x0000000190198a28 0x190098000 + 1051176
21  UIKitCore                       0x000000019027a168 UIApplicationMain(_:_:_:_:) + 104 (UIKit.swift:565)
22  Client                          0x00000001044eee28 main (in Client) (AppDelegate.swift:0) + 28200
23  dyld                            0x00000001b468ff08 0x1b4651000 + 257800