-
Notifications
You must be signed in to change notification settings - Fork 985
P3A crash fix #29382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P3A crash fix #29382
Conversation
899ddbb
to
e672af0
Compare
I DMed in slack, but the crash still happens with that change. |
6923195
to
1ebc34a
Compare
if there is no obvious fix, we should revert the whole thing while investigating |
1e7aa6b
to
b89ba2f
Compare
PR we can revert if needed #28362 ++ from me on reverting until there's a solid solution |
I verified the change in the current(updated) PR on Android and made sure there is no crash anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ as I mentioned above, the changes are verified on Android and no issue there anymore.
Released in v1.81.50 |
Resolves brave/brave-browser#46549
UpdateMetricValue
gets called by theHandleHistogramChange
loop inP3AService::Init
, which creates the map elements:brave-core/components/p3a/message_manager.cc
Line 159 in c3e0933
RemoveObsoleteLogs
. All elements injson_log_stores_
will be null if JSON reporting is deprecated (which is the case, via Griffin). It tries to callMetricLogStore::RemoveObsoleteLogs
on null pointers