-
Notifications
You must be signed in to change notification settings - Fork 974
[iOS] - Remove Bookmarks Export Popup #28136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[unowned self] _ in | ||
Task { | ||
let fileUrl = FileManager.default.temporaryDirectory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't pass in an unowned
reference to a Task
which isn't guaranteed to execute immediately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I reverted the change. It's because I had moved the code and when I moved it back because I realized it was a dumb idea, I kept reading BrowserViewController
instead of BookmarksViewController
lol. I kept thinking that BrowserViewController
can never disappear lol
Fixed!
…s. Remove unnecessary popup
2102465
to
952c7a2
Compare
Released in v1.78.44 |
Summary
Resolves brave/brave-browser#44654
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: