Skip to content

[iOS] - Remove unnecessary Bookmarks Export Popup #44654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 5 tasks
Brandon-T opened this issue Mar 13, 2025 · 1 comment · Fixed by brave/brave-core#28136
Closed
3 of 5 tasks

[iOS] - Remove unnecessary Bookmarks Export Popup #44654

Brandon-T opened this issue Mar 13, 2025 · 1 comment · Fixed by brave/brave-core#28136
Assignees

Comments

@Brandon-T
Copy link

Description

  • After exporting bookmarks, remove the unnecessary popup
  • Popup should only show success/fail when importing.
  • Popup should only show fail when exporting. Success is guaranteed by the time the share-sheet comes up.

Steps to reproduce

  1. Export Bookmarks
  2. Cancel/dismiss the share sheet.
  3. Popup shows success even if you didn't actually export anything

Actual result

  • Popup shows success even if you didn't actually export anything

Expected result

  • Shouldn't show anything. When the share sheet comes up, it's already known to be successfully exported.

Reproduces how often

Easily reproduced

Brave version

  • Any

Device/iOS version

  • Any

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@Brandon-T Brandon-T added the OS/iOS Fixes related to iOS browser functionality label Mar 13, 2025
@Brandon-T Brandon-T self-assigned this Mar 13, 2025
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Mar 14, 2025
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 29, 2025
@hffvld
Copy link
Contributor

hffvld commented Apr 29, 2025

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7.2
Brave build: 1.78 (91)
BraveCore: 1.78.91 (136.0.7103.48)

STEPS:

  1. Follow the STR/TP from [iOS] - Remove unnecessary Bookmarks Export Popup #44654 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the pop-up is not shown when tapping X when exporting bookmarks.
  • Verified that the pop-up is not shown when successfully exporting bookmarks.
  • Verified that pop-up is still shown when importing bookmarks.

Export Import
Screencast Screencast
1 2

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants