Add update filter lists button #24828
Conversation
cuba
force-pushed
the
js/updating-filter-lists
branch
from
c51c256 to
ff028b2
Compare
cuba
added
CI/skip-android
cuba
force-pushed
the
js/updating-filter-lists
branch
2 times, most recently
from
9907afe to
80baf8e
Compare
| var isUpdating: Bool { | ||
| return self == .updating | ||
| } | ||
|
|
||
| var isUpdated: Bool { | ||
| return self == .updated | ||
| } |
There was a problem hiding this comment.
These don't seem useful since your enum does not contain any associated values and thus can be compared directly
| do { | ||
| try await FilterListCustomURLDownloader.shared.updateFilterLists() | ||
| } catch { | ||
| // Handle the error |
There was a problem hiding this comment.
Error isn't handled?
There was a problem hiding this comment.
Yah I should handle this. I put the comment but wasn't sure how to deal with it and forgot about it. Thanks for catching this.
There was a problem hiding this comment.
Fixed, however since Task.retry swallows errors, the catch will never be triggered. Will fix the issue with Task.retry separately.
| @@ -54,6 +54,27 @@ import Preferences | |||
| } | |||
| } | |||
|
|
|||
| func updateFilterLists() async -> Bool { | |||
There was a problem hiding this comment.
this will run on main, is that ok?
There was a problem hiding this comment.
I believe this should be fine. The method does this:
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
There was a problem hiding this comment.
Okay then shit will require it always run on main then unless you use a task runner on the core side, if the @MainActor is ever removed from the parent type this will need to make sure its marked as MainActor again
cuba
force-pushed
the
js/updating-filter-lists
branch
from
80baf8e to
5d504a0
Compare
No we still want this. Desktop has it too. brave://components is for more "advanced" users |
Resolves brave/brave-browser#35982
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Screenshots
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-07-25.at.09.41.37.mp4