Skip to content

Have a way to force-update adblock lists #35982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShivanKaul opened this issue Jan 8, 2024 · 4 comments · Fixed by brave/brave-core#24828
Closed

Have a way to force-update adblock lists #35982

ShivanKaul opened this issue Jan 8, 2024 · 4 comments · Fixed by brave/brave-core#24828
Assignees
Labels
feature-request OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@ShivanKaul
Copy link
Collaborator

We don't currently have a way on iOS to force-update all components like we do on Desktop and Android, where a user can go to brave://components in the omnibox and manually press Update for components.

image

This is extremely important for when we need to ship an emergency component update out, like we do when there's widespread adblock list-related breakage. On iOS, AFAICT, there's nothing a user can do to make sure they have the latest version of an adblock list.

We don't need to have the update be per-component; a single button suffice somewhere in the app would suffice. For debugging purposes, it would also be nice to know the user's current version, but that's secondary in priority.

@kylehickinson
Copy link
Collaborator

Adblock on iOS is controlled by component updater as well, so a possible solution here would be to expose a way to access brave://components on iOS as well

@ShivanKaul ShivanKaul added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 9, 2024
@cuba cuba transferred this issue from brave/brave-ios Feb 12, 2024
@ShivanKaul ShivanKaul added the OS/iOS Fixes related to iOS browser functionality label Jun 28, 2024
@ShivanKaul
Copy link
Collaborator Author

We should look at the Android implementation of this, at least for the placement of the Update button: #35270. It would be best if this button lived in the Content Filtering settings page.

@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18.0 using version 1.70.117

Case: New Users

  • Ensured that Update Lists button is shown for Default Filter Lists and External Filter Lists.
  • Ensured that Update Lists button is only shown for External Filters Lists when URLs are added and not shown when URLs are removed again.
  • Ensured that button is replaced with Lists Updated message when tapping on the update button.
  • Ensured that button state is reset to default state (showing Update Lists) when re-entering the settings page.
  • Ensured that custom filters can be added and are applied on webpages.
example example example example example example
IMG_7346 IMG_7347 IMG_7348 IMG_7349 IMG_7350 IMG_7351

Case: Existing Users

  • Ensured that filter lists, external filters lists and custom filters are retained when upgrading from 1.69.169 -> 1.70.117.
  • Ensured that disabling Block 'Switch to App' Notices in settings and then upgrading will retain the switch state in Content Filtering and Settings page.
  • Ensured that Update Lists button works after upgrading for existing users and updated message is shown.
example example example example
IMG_7354 IMG_7355 IMG_7356 IMG_7357

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 19, 2024

Verified on iPad (7th Gen) running iOS 17.6 using version 1.70.117

Case: New Users

  • Ensured that Update Lists button is shown for Default Filter Lists and External Filter Lists.
  • Ensured that Update Lists button is only shown for External Filters Lists when URLs are added and not shown when URLs are removed again.
  • Ensured that button is replaced with Lists Updated message when tapping on the update button.
  • Ensured that button state is reset to default state (showing Update Lists) when re-entering the settings page.
  • Ensured that custom filters can be added and are applied on webpages.
example example example example
IMG_1618 IMG_1619 IMG_1620 IMG_1621

Case: Existing Users

  • Ensured that filter lists, external filters lists and custom filters are retained when upgrading from 1.69.169 -> 1.70.117.
  • Ensured that disabling Block 'Switch to App' Notices in settings and then upgrading will retain the switch state in Content Filtering and Settings page.
  • Ensured that Update Lists button works after upgrading for existing users and updated message is shown.
example example example
IMG_1622 IMG_1623 IMG_1624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass - iPad QA Pass - iPhone QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants