Skip to content

Update the latest translations from transifex for c74. #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Apr 26, 2019

Fixes brave/brave-browser#4258

Submitter Checklist:

Test Plan:

N/A

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 0.66.x - Nightly milestone Apr 26, 2019
@mkarolin mkarolin self-assigned this Apr 26, 2019
@mkarolin mkarolin force-pushed the maxk-update-c74-l10n branch from 69978a3 to aa49b80 Compare April 26, 2019 13:11
@mkarolin
Copy link
Collaborator Author

@mkarolin
Copy link
Collaborator Author

@bbondy are brave/brave-browser#4236 and brave/brave-browser#4212 expected to be addressed by this pull? I am not seeing any new Polish translations.

@mkarolin mkarolin changed the title WIP: Update the latest translations from transifex for c74. Update the latest translations from transifex for c74. Apr 26, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy
Copy link
Member

bbondy commented Apr 27, 2019

I was hoping they would be, but maybe they're not marked up correctly or something like that. You're good to merge in any case if CI is cool with the changes.

@mkarolin mkarolin merged commit 959764c into master Apr 27, 2019
@mkarolin mkarolin deleted the maxk-update-c74-l10n branch April 27, 2019 05:15
mkarolin added a commit that referenced this pull request Apr 27, 2019
Update the latest translations from transifex for c74.
mkarolin added a commit that referenced this pull request Apr 27, 2019
Update the latest translations from transifex for c74.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the latest translations from transifex for c74.
3 participants