Skip to content

Fixed crash when a tab is added to saved group (uplift to 1.66.x) #23229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fixed crash when a tab is added to saved group (uplift to 1.66.x) #23229

merged 1 commit into from
Apr 23, 2024

Conversation

brave-builds
Copy link
Collaborator

Uplift of #23227
fix brave/brave-browser#37160

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner April 23, 2024 05:45
@brave-builds brave-builds requested a review from a team April 23, 2024 05:45
@brave-builds brave-builds added this to the 1.66.x - Beta milestone Apr 23, 2024
@brave-builds brave-builds self-assigned this Apr 23, 2024
LaurenWags
LaurenWags approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.66.x is approved 👍🏻 QA has verified the fix on 1.67.x/Nightly as per #23227 (comment) and #23227 (comment).

@LaurenWags LaurenWags merged commit 9b307f8 into 1.66.x Apr 23, 2024
15 checks passed
@LaurenWags LaurenWags deleted the pr23227_fix_crash_when_tab_added_to_saved_group_1.66.x branch April 23, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @LaurenWags