Skip to content

Fixed crash when a tab is added to saved group #23227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 23, 2024

fix brave/brave-browser#37160

Widget is referred after group button is removed form widget.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

fix brave/brave-browser#37160

Widget is referred after group button is removed form widget.
@simonhong simonhong self-assigned this Apr 23, 2024
@simonhong simonhong marked this pull request as ready for review April 23, 2024 02:53
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit a2de173 into master Apr 23, 2024
18 checks passed
@simonhong simonhong deleted the fix_crash_when_tab_added_to_saved_group branch April 23, 2024 05:01
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 23, 2024
brave-builds added a commit that referenced this pull request Apr 23, 2024
brave-builds added a commit that referenced this pull request Apr 23, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Apr 23, 2024

Verified with

Brave | 1.67.34 Chromium: 124.0.6367.60 (Official Build) nightly (x86_64)
-- | --
Revision | 54f7c66f9f8a11b6f4fd36c6b3abc37841e4d19f
OS | macOS Version 13.6.6 (Build 22G630)

Used STR from brave/brave-browser#37160 (comment) but was not able to reproduce the crash on the following versions: 1.65.90, 1.65.114, 1.67.18.

Verified when using STR from brave/brave-browser#37160 (comment) and 1.67.34, there is no crash.

@MadhaviSeelam
Copy link

Reproduced the issue in Win 11 x64 using both 1.67.18 & 1.65.118.
Verified the issue in 1.67.35 and no crash occurred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when labeling formerly-backgrounded tab/window with newly created label
4 participants