Skip to content

Fixed wdp infobar is not shown properly after loading search.brave.com #23186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 21, 2024

fix brave/brave-browser#37705

This is partial fix but at least user could see proper wdp info if window is not resized as we need to have this fix in next stable RC.
As we still have wdp infobar layout issue if user changes window width, we ned to fix it as a f/u.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

fix brave/brave-browser#37705

Still we have wdp infobar layout issue if user changes window width.
@simonhong simonhong requested a review from sangwoo108 April 21, 2024 09:23
@simonhong simonhong self-assigned this Apr 21, 2024
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong changed the title Fixed wdb infobar is not shown properly after loading search.brave.com Fixed wdp infobar is not shown properly after loading search.brave.com Apr 21, 2024
@simonhong simonhong merged commit 292bd9e into master Apr 21, 2024
20 checks passed
@simonhong simonhong deleted the wdp_infobar_layout branch April 21, 2024 12:39
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 21, 2024
brave-builds added a commit that referenced this pull request Apr 21, 2024
brave-builds added a commit that referenced this pull request Apr 21, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 22, 2024

Verification PASSED using

Brave | 1.67.30 Chromium: 124.0.6367.60 (Official Build) nightly (64-bit)
-- | --
Revision | e692f54729b32dc0d1a275509f1d77fa07d96363
OS | Windows 11 Version 23H2 (Build 22631.3447)
  1. Install 1.67.30
  2. launch Brave
  3. enter a string (test) in the URL bar or search.brave.com

Confirmed the WDP infobar shown correct text. Help improve Brave Search by sending anonymous usage data...

2024-04-22_10h27_06.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial text shown for the Help improve.. text in the WDP banner
3 participants