Skip to content

Partial text shown for the Help improve.. text in the WDP banner #37705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MadhaviSeelam opened this issue Apr 18, 2024 · 3 comments · Fixed by brave/brave-core#23186
Closed
Assignees
Labels
bug OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 18, 2024

Description

Help improve... text is cut off and partial text in the Search promo banner.

Steps to Reproduce

  1. Install 1.65.114
  2. launch Brave
  3. enter a string (test) in the URL bar or search.brave.com

Actual result:

partial text in Help improve Brave Search by sending shown

example example
image image

Expected result:

Text should read Help improve Brave Search by sending anonymous usage data...
 
image

Reproduces how often:

Brave version (brave://version info)

Brave | 1.65.114 Chromium: 124.0.6367.60 (Official Build) (64-bit)
-- | --
Revision | f1e2cbb65e11340d9040d5ef0b0115c7a5206207
OS | Windows 11 Version 23H2 (Build 22631.3447)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron
cc: @brave/qa-team

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 18, 2024
@simonhong
Copy link
Member

Checking

simonhong added a commit to brave/brave-core that referenced this issue Apr 21, 2024
fix brave/brave-browser#37705

Still we have wdp infobar layout issue if user changes window width.
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 21, 2024
@MadhaviSeelam MadhaviSeelam changed the title Partial text shown for the Help improve.. text in the Search promo banner Partial text shown for the Help improve.. text in the WDP banner Apr 22, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Apr 23, 2024

This requires 1.65.118 or higher to test.

@MadhaviSeelam
Copy link
Author

Verification PASSED using

Brave | 1.65.118 Chromium: 124.0.6367.60 (Official Build) (64-bit)
-- | --
Revision | 8ecd7a3ff4b4d81f25b94f5b92ab7130587888cd
OS | Windows 11 Version 23H2 (Build 22631.3447)
  1. Installed 1.65.118
  2. launched Brave
  3. entered a string (test) in the URL bar or search.brave.com

Confirmed the WDP infobar shown correct text. Help improve Brave Search by sending anonymous usage data...

2024-04-23_08h54_14.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants