Skip to content

Remove shorts for youtube #23130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Remove shorts for youtube #23130

merged 1 commit into from
Apr 26, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Apr 17, 2024

Resolves brave/brave-browser#36465

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Apr 17, 2024
@deeppandya deeppandya added this to the 1.67.x - Nightly milestone Apr 17, 2024
@deeppandya deeppandya requested a review from tapanmodh April 17, 2024 17:16
@deeppandya deeppandya self-assigned this Apr 17, 2024
@deeppandya deeppandya requested a review from a team as a code owner April 17, 2024 17:16
Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string reviewers ++

@deeppandya deeppandya merged commit 071fad8 into master Apr 26, 2024
20 checks passed
@deeppandya deeppandya deleted the remove_shorts_android branch April 26, 2024 15:26
brave-builds added a commit that referenced this pull request Apr 26, 2024
@kjozwiak
Copy link
Member

kjozwiak commented May 1, 2024

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.67.57 Chromium: 124.0.6367.118 (Official Build) canary (64-bit)
--- | ---
Revision | e95911d7eb4ea56fa157bcfa7ddd27fbd96a98b9
OS | Android 14; Build/AP21.240305.005; 34; REL
  • ensured that Block YouTube Shorts has been added into Hamburger Menu -> Settings -> Media
  • ensured that Shorts are visible under the Home, Search & Trending pages by default
    • ensured that Block YouTube Shorts is disabled by default
    • ensured that restarting the browser retains the current state (both Enabled & Disabled)
  • ensured that once Block YouTube Shorts has been enabled, Shorts are not being displayed via Home, Trending & Search

Default/Disabled (Shorts visible/being displayed)

Example Example Example Example Example Example Example
Screenshot_20240501-172704 Screenshot_20240501-172714 Screenshot_20240501-172731 Screenshot_20240501-173251 Screenshot_20240501-173301 Screenshot_20240501-173326 Screenshot_20240501-173338

Enabling/Disabling and checking Home

Enabling/Disabling and checking Trending

Enabling/Disabling and checking Search Results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] YT Improvements - Setting to remove Shorts
4 participants