Skip to content

[Android] YT Improvements - Setting to remove Shorts #36465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timchilds opened this issue Feb 29, 2024 · 10 comments · Fixed by brave/brave-core#23130
Closed

[Android] YT Improvements - Setting to remove Shorts #36465

timchilds opened this issue Feb 29, 2024 · 10 comments · Fixed by brave/brave-core#23130
Assignees
Labels
enhancement OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@timchilds
Copy link

timchilds commented Feb 29, 2024

Description

There is a new filter list available to block YouTube Shorts:
https://github.com/brave/adblock-lists/blob/master/brave-lists/yt-shorts.txt

Add a toggle to enable/disable this filter list under settings -> media:

Block YouTube Shorts
Blocks Shorts from the home page, trending page and search results on youtube.com.

cc @deeppandya @ryanbr @anthonypkeane

@timchilds timchilds added the OS/Android Fixes related to Android browser functionality label Feb 29, 2024
@timchilds timchilds changed the title [Android] YT Improvements - Remove Shorts [Android] YT Improvements - Setting to remove Shorts Feb 29, 2024
@timchilds timchilds added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 29, 2024
@deeppandya
Copy link
Contributor

@timchilds should it be enabled by default ?

@deeppandya
Copy link
Contributor

@timchilds
Copy link
Author

@deeppandya the toggle should be off (disabled) by default.

We should not block Shorts by default - blocking should be user initiated.

@deeppandya
Copy link
Contributor

@deeppandya the toggle should be off (disabled) by default.

We should not block Shorts by default - blocking should be user initiated.

yeah i agree. Thanks

@kjozwiak
Copy link
Member

kjozwiak commented May 1, 2024

The above requires 1.66.97 or higher for 1.66.x verification(s) 👍 @hffvld @Uni-verse can also find some STR/Cases that were used for Nightly verification via brave/brave-core#23130 (comment).

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 3, 2024
@hffvld
Copy link
Contributor

hffvld commented May 3, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 14 AP31.240322.023 release-keys
Brave build: 1.66.95
Chromium: 124.0.6367.91 (Official Build) beta (64-bit) 

Filed follow-up issue #38059

STEPS:

  1. Launch Brave > Three-dot menu > Settings
  2. Media > Verify that the Block YouTube Shrots toggle switch is there
  3. Enable Block YouTube Shrots toggle switch > Close the settings
  4. Go to www.youtube.com > Verify that Shorts are not shown on the Home tab
  5. Tap the Compass/Hamburger menu button > Trending > Verify that Trending Shorts are not shown
  6. Tap the search button on YT > Send a query > Verify that Shorts are not shown

ACTUAL RESULTS:

  • Verified that the Block YouTube Shrots toggle switch is shown in the Media section
  • Verified that Shorts are not shown on the YT Home tab
  • Verified that Trending Shorts are not shown on the YT Trending tab
  • Verified that Shorts are not shown in the search results

Galaxy Tab S8
1 2 3 4
1 2 3 4
Tab_Shorts.mov
Pixel 7
1 2 3 4
1 2 3 4
2024-05-03_11-41-26.mp4

@anthonypkeane
Copy link

@timchilds can you check out #36465 (comment) and see if that is possible? Thanks

@timchilds
Copy link
Author

@saksham-81 engineering are looking in to this now. A patch will be rolled out soon.

@deeppandya
Copy link
Contributor

@timchilds @saksham-81 #36465 (comment) is updated. we are not showing Shorts icon now. Thanks to @ryanbr

@KvalheimRacing
Copy link

KvalheimRacing commented Aug 29, 2024

Unhook also have an option to make YT main screen completely empty. I didn't find any option to enable this in brave. Would help productivity and focus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants