Skip to content

Fix crash when "New Private Window with Tor" is selected without a window open. #23126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

sangwoo108
Copy link
Contributor

When there's no open window, the "New Private Window with Tor" menu on the dock icon causes crash - technically, it's CHECK() failure. In order to fix this, pass Profile directly instead of Browser.

Resolves brave/brave-browser#37649

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open browser
  • Close window only - with cmd shift w
  • Right click the brave icon
  • Click "New Private Window With Tor"
  • There should be no crash and Tor window should open.

…ndow open.

When there's no open window, the "New Private Window with Tor" menu on
the dock icon causes crash - technically, it's CHECK() failure.
In order to fix this, pass `Profile` directly instead of `Browser`.
@sangwoo108 sangwoo108 marked this pull request as ready for review April 17, 2024 13:50
@sangwoo108 sangwoo108 requested review from boocmp and iefremov April 17, 2024 13:50
@sangwoo108 sangwoo108 merged commit 7d541d2 into master Apr 17, 2024
20 checks passed
@sangwoo108 sangwoo108 deleted the sko/tor-crash branch April 17, 2024 21:06
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 17, 2024
@iefremov
Copy link
Contributor

@sangwoo108 pls request uplifts

@kjozwiak
Copy link
Member

Verification PASSED on macOS 14.4.1 x64 using the following build(s):

Brave | 1.67.25 Chromium: 124.0.6367.60 (Official Build) nightly (x86_64)
--- | ---
Revision | 9532ed663fa5eb013eb7b9840962b54ca6f2dbf4
OS | macOS Version 14.4.1 (Build 23E224)

Reproduced the original crash with 1.67.19 Chromium: 124.0.6367.60 using the STR/Cases outlined via #23126 (comment) as per the following:

Screenshot 2024-04-19 at 11 41 16 PM

Using the same STR/Cases as mentioned above, verified that Brave was not crashing when opening Tor windows via the Brave icon when all the other windows have been closed. Also ensured that Private & Normal windows are opening without issues.

kjozwiak pushed a commit that referenced this pull request Apr 20, 2024
…ndow open. (uplift to 1.66.x) (#23171)

Uplift of #23126 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Apr 20, 2024
…ndow open. (uplift to 1.65.x) (#23172)

Uplift of #23126 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in brave::NewOffTheRecordWindowTor
4 participants