Fix crash when "New Private Window with Tor" is selected without a window open. (uplift to 1.65.x) (#23172)

Uplift of #23126 (squashed) to release

Author: brave-builds

browser/brave_app_controller_mac.mm

@@ -201,7 +201,7 @@ - (void)executeCommand:(id)sender withProfile:(Profile*)profile {
 
 #if BUILDFLAG(ENABLE_TOR)
   if (tag == IDC_NEW_OFFTHERECORD_WINDOW_TOR) {
-    brave::NewOffTheRecordWindowTor([self getBrowser]);
+    brave::NewOffTheRecordWindowTor(profile);
     return;
   }
 #endif  // BUILDFLAG(ENABLE_TOR)

browser/ui/browser_commands.cc

@@ -110,12 +110,17 @@ bool CanTakeTabs(const Browser* from, const Browser* to) {
 
 void NewOffTheRecordWindowTor(Browser* browser) {
   CHECK(browser);
-  if (browser->profile()->IsTor()) {
-    chrome::OpenEmptyWindow(browser->profile());
+  NewOffTheRecordWindowTor(browser->profile());
+}
+
+void NewOffTheRecordWindowTor(Profile* profile) {
+  CHECK(profile);
+  if (profile->IsTor()) {
+    chrome::OpenEmptyWindow(profile);
     return;
   }
 
-  TorProfileManager::SwitchToTorProfile(browser->profile());
+  TorProfileManager::SwitchToTorProfile(profile);
 }
 
 void NewTorConnectionForSite(Browser* browser) {

browser/ui/browser_commands.h

@@ -11,12 +11,15 @@
 
 class Browser;
 class GURL;
+class Profile;
 
 namespace brave {
 
 bool HasSelectedURL(Browser* browser);
 void CleanAndCopySelectedURL(Browser* browser);
-void NewOffTheRecordWindowTor(Browser*);
+void NewOffTheRecordWindowTor(Browser* browser);
+void NewOffTheRecordWindowTor(Profile* profile);
+
 void NewTorConnectionForSite(Browser*);
 void ShowWalletBubble(Browser* browser);
 void ShowApproveWalletBubble(Browser* browser);