Skip to content

Skus threading t3 (uplift to 1.63.x) #22315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 26, 2024

Uplift of #22228
Resolves brave/brave-browser#35933

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner February 26, 2024 14:38
@kjozwiak kjozwiak added this to the 1.63.x - Release #3 milestone Feb 26, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.63.x approved 👍 noplatform keeps failing which is a known issue as per https://bravesoftware.slack.com/archives/C7VLGSR55/p1708974451327989 and not related to this specific PR. Other platforms passed without any issues/failures.

QA has verified the PR on Nightly using 1.65.x as per #22228 (comment) & https://bravesoftware.slack.com/archives/C04KPE0BUDU/p1708937243287289?thread_ts=1708453456.617779&cid=C04KPE0BUDU.

@kjozwiak kjozwiak merged commit 68b61c9 into 1.63.x Feb 26, 2024
@kjozwiak kjozwiak deleted the pr22228_skus-threading-t3_1.63.x branch February 26, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants