-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Do not run SKUs rust SDK on UI thread #35933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run SKUs rust SDK on UI thread #35933
Comments
Re opened because we reverted brave/brave-core#22109 and brave/brave-core#22169 |
The above requires |
Verification
|
example | example | example | example | example | example | example |
---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Brave VPN - FAILED (*)
Steps:
- installed
1.63.164
- launched Brave using
--env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev
- loaded
account.bravesoftware.com
- entered basic-auth credentials
- entered
[email protected]
and clickedGet login link
- clicked on
Browse plans
- clicked on
Start free trial
forBrave VPN
- completed
Stripe
checkout using test credit-card details
Unable to confirm working Brave VPN
credentials due to #36321
example | example | example | example | example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Brave Talk Premium - PASSED
Steps:
- installed
1.63.164
- launched Brave using
--env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev
- loaded
account.bravesoftware.com
- entered basic-auth credentials
- entered
[email protected]
and clickedGet login link
- clicked on
Browse plans
- clicked on
Start free trial
forBrave Talk Premium
- completed
Stripe
checkout using test credit-card details
Confirmed working Brave Talk Premium
credentials
example | example | example | example | example | example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Cancel product subscriptions - PASSED
Leo
example | example | example | example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Brave VPN
example | example | example | example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Brave Talk Premium
example | example | example | example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
status
field for each product, from brave://skus-internals
Leo Premium |
Brave VPN |
Brave Talk Premium |
---|---|---|
![]() |
![]() |
![]() |
Re-use (new profile) cancelled but still-active subscriptions - PASSED
Renew plan - PASSED
Verified on
Leo subscriptionSTEPS:
ACTUAL RESULTS:
Purchase a new subscription and link to the account timestamp_13-21-33_13-22-36.mp4Activate linked subscription on another device timestamp_13-29-06_13-30-52.mp4VPN subscriptionSTEPS:
ACTUAL RESULTS:
Purchase a new subscription and link to the account timestamp_13-43-13_13-44-14.mp4Activate linked subscription on another device timestamp_13-44-24_13-45-12.mp4 |
Verification
Purchase and use subscriber credentials Case 1: Purchase Brave VPN & use the credentials -
Confirmed Brave VPN credentials work as expected.
Case 2: Purchase Leo Premium & use the credentials -
Case 3: Purchase Brave Talk premium & use the credentials -
Confirmed Brave talk credentials are successfully loaded
Case 4: Brave Search Premium -
Confirmed able to purchase Brave Search ![]() Cancel subscriptions Case 5: Cancel Brave VPN -
Confirmed successfully cancelled the subscription
Case 6: Cancel Leo Premium -
Case 7: Cancel Brave talk Premium-
Case 8: Cancel Brave Search - Re-login with cancelled subscriptions
Case 9: Login with cancelled subscription but still active VPN credentials - `PASSED`
Case 10: Login with cancelled subscription but still active Leo credentials -
Case 11: Login with cancelled subscription but still active Brave talk credentials -
|
Verification PASSED on
Using the account that purchased
Using a Google account that has never purchased any
Purchasing Leo via
Linking with Desktop using
Cancelling Leo subscription via
|
Verification
|
example | example | example | example | example |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
Brave Talk Premium
example | example | example |
---|---|---|
![]() |
![]() |
![]() |
Cancellations - PASSED
example | example | example | example | example | example | example |
---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Re-use (new profile) existing cancelled (but still Active
) credentials - PASSED
example | example | example | example | example | example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
It takes a long time and blocks the execution of the UI.
The text was updated successfully, but these errors were encountered: