Skip to content

Do not run SKUs rust SDK on UI thread #35933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nvonpentz opened this issue Feb 9, 2024 · 8 comments · Fixed by brave/brave-core#22109, brave/brave-core#22169 or brave/brave-core#22228
Closed

Comments

@nvonpentz
Copy link

It takes a long time and blocks the execution of the UI.

@nvonpentz nvonpentz self-assigned this Feb 9, 2024
@nvonpentz nvonpentz moved this to Alignment #3 - Mobile MVP in Browser AI Feb 9, 2024
@nvonpentz nvonpentz added the OS/Android Fixes related to Android browser functionality label Feb 20, 2024
@mattmcalister mattmcalister added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Feb 20, 2024
@github-project-automation github-project-automation bot moved this from Alignment #3 - Mobile MVP to Done in Browser AI Feb 20, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Feb 20, 2024
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 21, 2024
@nvonpentz nvonpentz reopened this Feb 22, 2024
@nvonpentz
Copy link
Author

Re opened because we reverted brave/brave-core#22109 and brave/brave-core#22169

@kjozwiak kjozwiak added QA/Test-All-Platforms and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 26, 2024
@brave-builds brave-builds removed this from the 1.64.x - Beta milestone Feb 26, 2024
@brave-builds brave-builds added this to the 1.63.x - Release #3 milestone Feb 26, 2024
@kjozwiak
Copy link
Member

The above requires 1.63.164 or higher for 1.63.x verification 👍

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 27, 2024
@stephendonner
Copy link

stephendonner commented Feb 27, 2024

Verification PASSED using

Brave | 1.63.164 Chromium: 122.0.6261.69 (Official Build) (x86_64)
-- | --
Revision | 0a640ded5b59268307d1ae11b74646763cb82b4c
OS | macOS Version 11.7.10 (Build 20G1427)

Purchase and use credentials - PASSED

Leo Premium - PASSED

Steps:

  1. installed 1.63.164
  2. launched Brave using --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev
  3. loaded account.bravesoftware.com
  4. entered basic-auth credentials
  5. entered [email protected] and clicked Get login link
  6. clicked on Browse plans
  7. clicked on Buy now for Leo Premium
  8. completed Stripe checkout using test credit-card details

Confirmed working Leo Premium credentials

example example example example example example example
Screen Shot 2024-02-27 at 4 43 46 PM Screen Shot 2024-02-27 at 4 43 49 PM Screen Shot 2024-02-27 at 4 43 55 PM Screen Shot 2024-02-27 at 4 44 27 PM Screen Shot 2024-02-27 at 4 44 43 PM Screen Shot 2024-02-27 at 4 45 10 PM Screen Shot 2024-02-27 at 4 45 13 PM

Brave VPN - FAILED (*)

Steps:

  1. installed 1.63.164
  2. launched Brave using --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev
  3. loaded account.bravesoftware.com
  4. entered basic-auth credentials
  5. entered [email protected] and clicked Get login link
  6. clicked on Browse plans
  7. clicked on Start free trial for Brave VPN
  8. completed Stripe checkout using test credit-card details

Unable to confirm working Brave VPN credentials due to #36321

example example example example example
Screen Shot 2024-02-27 at 4 57 50 PM Screen Shot 2024-02-27 at 4 57 52 PM Screen Shot 2024-02-27 at 4 58 20 PM Screen Shot 2024-02-27 at 4 58 33 PM Screen Shot 2024-02-27 at 4 58 37 PM

Brave Talk Premium - PASSED

Steps:

  1. installed 1.63.164
  2. launched Brave using --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev
  3. loaded account.bravesoftware.com
  4. entered basic-auth credentials
  5. entered [email protected] and clicked Get login link
  6. clicked on Browse plans
  7. clicked on Start free trial for Brave Talk Premium
  8. completed Stripe checkout using test credit-card details

Confirmed working Brave Talk Premium credentials

example example example example example example
Screen Shot 2024-02-27 at 4 52 21 PM Screen Shot 2024-02-27 at 4 52 56 PM Screen Shot 2024-02-27 at 4 53 03 PM Screen Shot 2024-02-27 at 4 53 29 PM Screen Shot 2024-02-27 at 4 53 34 PM Screen Shot 2024-02-27 at 4 53 44 PM

Cancel product subscriptions - PASSED

Leo

example example example example
Screen Shot 2024-02-27 at 5 31 35 PM Screen Shot 2024-02-27 at 5 31 39 PM Screen Shot 2024-02-27 at 5 31 42 PM Screen Shot 2024-02-27 at 5 31 51 PM

Brave VPN

example example example example
308388060-8469bbf5-f40a-40b6-ba39-178cfc34f99f Screen Shot 2024-02-27 at 5 32 20 PM Screen Shot 2024-02-27 at 5 32 24 PM Screen Shot 2024-02-27 at 5 32 31 PM

Brave Talk Premium

example example example example
Screen Shot 2024-02-27 at 5 32 31 PM Screen Shot 2024-02-27 at 5 32 37 PM Screen Shot 2024-02-27 at 5 32 40 PM Screen Shot 2024-02-27 at 5 32 50 PM

status field for each product, from brave://skus-internals

Leo Premium Brave VPN Brave Talk Premium
Screen Shot 2024-02-27 at 5 34 05 PM Screen Shot 2024-02-27 at 5 34 08 PM Screen Shot 2024-02-27 at 5 33 58 PM

Re-use (new profile) cancelled but still-active subscriptions - PASSED

Leo

example example
Screenshot 2024-02-28 at 12 26 03 AM Screenshot 2024-02-28 at 12 26 40 AM

VPN

Screenshot 2024-02-28 at 12 13 34 AM

Talk

Screenshot 2024-02-28 at 12 10 10 AM 1

Renew plan - PASSED

Talk, Leo, VPN

pre-renewal, expires_at

Screenshot 2024-02-28 at 12 42 02 AM

post-renewal, expires_at values for Talk, Leo, and VPN

example example example
Screenshot 2024-02-28 at 12 52 07 AM Screenshot 2024-02-28 at 12 52 31 AM Screenshot 2024-02-28 at 12 52 46 AM

@hffvld
Copy link
Contributor

hffvld commented Feb 27, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240119.009 release-keys
Brave build: 1.63.164
Chromium: 122.0.6261.69 (Official Build) (64-bit) 

Leo subscription

STEPS:

  1. Launch Brave
  2. Three-dot menu > Leo
  3. Leo's three-dot menu > Go Premium
  4. Purchase new Leo subscription > Verify new subscription can be purchased
  5. Brave's three-dot menu > Settings > Leo
  6. Link purchase to your Brave account
  7. Follow the flow > Verify subscription can be linked to your account
  8. Use the Leo > Verify Brave/Leo is not freezing

ACTUAL RESULTS:

  • Verified that a new Leo subscription can be purchased
  • Verified that Leo subscription can be linked to the Brave account
  • Verified that Brave is not crashing when accessing account.brave.com and linking the subscription
  • Verified that Brave/Leo is not freezing

Purchase a new subscription and link to the account

timestamp_13-21-33_13-22-36.mp4

Activate linked subscription on another device

timestamp_13-29-06_13-30-52.mp4
VPN subscription

STEPS:

  1. Launch Brave
  2. Three-dot menu > Brave VPN
  3. Purchase new VPN subscription > Follow the flow to enable VPN > Verify VPN subscription can be purchased
  4. Brave Firewall + VPN > Link purchase to your Brave account
  5. Follow the flow > Verify VPN subscription can be linked to Brave account
  6. Go to Play Store > Subscriptions > Cancel VPN subscription
  7. Go back to Brave > Tree-dot menu > Brave VPN > Verify VPN subscription can be canceled

ACTUAL RESULTS:

  • Verified that a new VPN subscription can be purchased
  • Verified VPN can be enabled/disabled
  • Verified that VPN subscription can be canceled
  • Verified that VPN subscription can be linked to Brave account
  • Verified that Brave is not crashing when accessing account.brave.com and linking the subscription

Purchase a new subscription and link to the account

timestamp_13-43-13_13-44-14.mp4

Activate linked subscription on another device

timestamp_13-44-24_13-45-12.mp4

@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 27, 2024

Verification PASSED using

Brave | 1.63.164 Chromium: 122.0.6261.69 (Official Build) (64-bit)
-- | --
Revision | 0a640ded5b59268307d1ae11b74646763cb82b4c
OS | Windows 11 Version 23H2 (Build 22631.3155)

Purchase and use subscriber credentials

Case 1: Purchase Brave VPN & use the credentials - PASSED

  1. installed 1.63.164
  2. launched Brave
  3. opened account.bravesoftware.com
  4. entered basic-auth credentials
  5. entered [email protected], clicked Get login link
  6. clicked the link in the email
  7. clicked Browse plans
  8. clicked on Start free trial for Brave VPN
  9. completed the Stripe purchase flow
  10. confirmed I could connect to the VPN
  11. opened browserleaks.com/dns in a new tab and it shows correct VPN’s country location
  12. closed Brave browser
  13. disconnected from the BraveVPN connection from taskbar VPN icon
  14. relaunched Brave
  15. confirmed able to connect to VPN via VPN panel
  16. opened brave://skus-internals and clicked Fetch SKUs state

Confirmed Brave VPN credentials work as expected.
Confirmed Brave VPN connect/disconnect work as expected

example example example example example example example
image image image image image image image

Case 2: Purchase Leo Premium & use the credentials - PASSED

  1. installed 1.63.164
  2. launched Brave
  3. opened account.bravesoftware.com
  4. entered basic-auth credentials
  5. entered [email protected], clicked Get login link
  6. clicked the link in the email
  7. clicked Browse plans
  8. clicked Buy now for Leo Premium
  9. completed the Stripe purchase flow
  10. confirmed Leo credentials are successfully loaded
  11. clicked Summarize this page
  12. clicked I understand
  13. closed Brave browser
  14. confirmed page summarization worked as expected
  15. relaunched Brave
  16. opened brave://skus-internals and clicked Fetch SKUs state
  • Confirmed Leo credentials work as expected.
  • Confirmed Leo summarization work as expected
example example
image image

Case 3: Purchase Brave Talk premium & use the credentials - PASSED

  1. installed 1.63.164
  2. launched Brave
  3. opened account.bravesoftware.com
  4. entered basic-auth credentials
  5. entered [email protected], clicked Get login link
  6. clicked the link in the email
  7. clicked Browse plans
  8. clicked Start free trial for Brave Talk premium
  9. completed the Stripe purchase flow
  10. confirmed Brave talk credentials are successfully loaded
  11. relaunched Brave

Confirmed Brave talk credentials are successfully loaded

example example example
image image image

Case 4: Brave Search Premium - PASSED

  1. installed 1.63.164
  2. launched Brave
  3. opened account.bravesoftware.com
  4. entered basic-auth credentials
  5. entered [email protected], clicked Get login link
  6. clicked the link in the email
  7. clicked Browse plans
  8. clicked Start free trial for Brave Search premium
  9. completed the Stripe purchase flow

Confirmed able to purchase Brave Search

image

Cancel subscriptions

Case 5: Cancel Brave VPN - PASSED

  1. Continue from Case 1 VPN subscription
  2. clicked Cancel on the subscription
  3. clicked Cancel subscription
  4. clicked Return to account

Confirmed successfully cancelled the subscription

example example example example
image image image image

Case 6: Cancel Leo Premium - PASSED

  1. Continue from Case 2 Purchase Leo
  2. clicked Cancel plan
  3. clicked Cancel subscription
  4. clicked Return to account
  • Confirmed successfully cancelled the subscription
  • Confirmed able to access premium models
example example example example
image image image image

Case 7: Cancel Brave talk Premium- PASSED

  1. Continue from Case 3 Brave talk
  2. clicked Cancel plan
  3. clicked Cancel subscription
  4. clicked Return to account
  5. clicked Brave talk icon in the sidebar
  • Confirmed successfully cancelled the subscription
  • Confirmed able to start Brave talk
example example example example
image image image image

Case 8: Cancel Brave Search - PASSED

  1. Continue from Case 4 Brave Search
  2. clicked Cancel plan
  3. clicked Cancel subscription
  4. clicked Return to account
example example example example
image image image image

Re-login with cancelled subscriptions

Case 9: Login with cancelled subscription but still active VPN credentials - `PASSED`
  1. continued from Case 5
    -cancelled subscription [email protected]
  2. launch Brave new profile
  3. login to VPN subscription
example example example
image image image

Case 10: Login with cancelled subscription but still active Leo credentials - PASSED

  1. continued from Case 6
    -cancelled subscription [email protected]
  2. launch Brave new profile
  3. login to Leo subscription
example example
image image

Case 11: Login with cancelled subscription but still active Brave talk credentials - PASSED

  1. continued from Case 7
    -cancelled subscription [email protected]
  2. launch Brave new profile
  3. login to Brave talk subscription
example example
image image

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 27, 2024

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.63.164 Chromium: 122.0.6261.69 (Official Build) (64-bit) 
Revision	0a640ded5b59268307d1ae11b74646763cb82b4c
OS	Android 13; Build/TP1A.220624.014; 33; REL

Case 1: VPN

  • Ensured purchasing VPN using IAP is successful and VPN is enabled.
  • Ensured linking IAP on Android to account.brave.com is successful.
  • Ensured restoring IAP on fresh profile is successful after completing purchase.
  • Ensured loading credentials for VPN (purchased on Android) on desktop client (Nightly) is successful
Example Example Example Example Example Example
Screenshot 2024-02-27 at 3 10 21 PM Screenshot 2024-02-27 at 3 11 51 PM Screenshot 2024-02-27 at 3 13 31 PM Screenshot 2024-02-27 at 3 13 44 PM Screenshot 2024-02-27 at 3 14 03 PM Screenshot 2024-02-27 at 3 35 09 PM

Case 2: Leo

  • Ensured loading credentials from account.brave.com from existing subscription is successful and Leo Premium is activated.
  • Ensured IAP flow works and Leo Premium is enabled.
  • Ensured linking IAP to account.brave.com is successful.
Loading credentials Loading credentials IAP IAP Link IAP Link IAP
Screenshot 2024-02-27 at 3 53 38 PM Screenshot 2024-02-27 at 3 54 08 PM Screenshot 2024-02-27 at 4 08 21 PM Screenshot 2024-02-27 at 4 08 44 PM Screenshot 2024-02-27 at 4 10 23 PM Screenshot 2024-02-27 at 4 11 24 PM

Leo on Desktop using Android Purchase

Screenshot 2024-02-27 at 4 18 47 PM

@kjozwiak
Copy link
Member

kjozwiak commented Feb 28, 2024

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.63.164 Chromium: 122.0.6261.69 (Official Build) (64-bit)
--- | ---
Revision | 0a640ded5b59268307d1ae11b74646763cb82b4c
OS | Android 14; Build/AP21.240119.009; 34; REL

Logging/Restore with an account that previously purchased via GPS - PASSED

Using the account that purchased Premium via the following account using a real CC #, went through the following:

  • installed/launched 1.63.164 Chromium: 122.0.6261.69
  • loaded https://account.brave.com and logged into the account that already purchased a Leo premium subscription
    • ensured that the SKU credentials restored without any issues once logged into the account (basically instantly restored)
  • once restored, ensured that Leo became Premium and that both the Mixtral & Claude LLM's appeared as Unlimited
    • also ensured that PERMIUM is being displayed at the top of the Leo window
Example Example Example
1000001451 1000001452 1000001453
  • ensured that Cancelling via https://account.brave.com correctly displayed a message about cancelling via GPS
    • ensured that the user is being redirected to https://support.google.com/googleplay/answer/7018481
Example Example
Screenshot_20240227-190318 Screenshot_20240227-190324

Logging/Restore with an account that never purchased via GPS - PASSED

Using a Google account that has never purchased any Premium features, logged into account.brave.com using the account that was used via the following account where a real CC purchase was done using GPS.

  • installed/launched 1.63.164 Chromium: 122.0.6261.69
  • loaded https://account.brave.com and logged into the account that already purchased a Leo premium subscription
    • ensured that the SKU credentials restored without any issues once logged into the account
    • SKU credentials took ~10s or so to load once Refresh Leo was clicked under Subscriptions
  • once restored, ensured that Leo became Premium and that both the Mixtral & Claude LLM's appeared as Unlimited
    • also ensured that PERMIUM is being displayed at the top of the Leo window
Example Example Example Example Example Example Example
1000001456 1000001457 1000001458 1000001459 1000001460 1000001461 1000001462
  • ensured that Cancelling via https://account.brave.com correctly displayed a message about cancelling via GPS
    • ensured that the user is being redirected to https://support.google.com/googleplay/answer/7018481
Example Example
Screenshot_20240227-192044 Screenshot_20240227-192048

Purchasing Leo using real CC# on a new account via GPS - PASSED

  • launched 1.63.164 Chromium: 122.0.6261.69
  • purchased Leo premium via Hamburger Menu -> Settings -> Leo -> Go Premium (using a real CC # via production)
  • once Leo has been purchased, tapped on Link purchase to your Brave account via the Leo settings
  • ensured that https://account.brave.com/?intent=link-order&product=leo (specifically intent=link-order)
  • used/logged into an account that doesn't have any Premium products associated with the account
  • once logged into the Brave Account, tapped on Link my subscription now
    • ensured that the Success! Your subscription is now linked message was displayed once linked
  • ensured that Leo appeared as a purchased premium product
    • ensured that Purchased on Android is visible/being displayed

Purchasing Leo via Production

Example Example Example Example
1000001486 1000001488 1000001489 1000001491

Linking with Desktop using Production

Example Example Example Example Example
1000001492 1000001493 1000001494 1000001495 1000001496

Cancelling Leo subscription via Production

Example Example Example Example Example Example
1000001497 1000001498 1000001499 1000001501 1000001500 1000001502

@stephendonner
Copy link

stephendonner commented Feb 28, 2024

Verification PASSED using

Brave	1.63.165 Chromium: 122.0.6261.94 (Official Build) (64-bit) 
Revision	fed0fcc915f6d9e1db871202f0304c8d582a73de
OS	Linux

Confirmed no crashes or hangs when signing up, cancelling, and re-using credentials for Leo Premium and Brave Talk Premium

New-credential signups - PASSED

Leo Premium

example example example example example
Screen Shot 2024-02-28 at 8 49 47 AM Screen Shot 2024-02-28 at 8 50 40 AM Screen Shot 2024-02-28 at 8 55 39 AM Screen Shot 2024-02-28 at 8 56 02 AM Screen Shot 2024-02-28 at 8 56 33 AM

Brave Talk Premium

example example example
Screen Shot 2024-02-28 at 9 00 28 AM Screen Shot 2024-02-28 at 9 04 40 AM Screen Shot 2024-02-28 at 9 10 21 AM

Cancellations - PASSED

example example example example example example example
Screen Shot 2024-02-28 at 9 15 32 AM Screen Shot 2024-02-28 at 9 15 36 AM Screen Shot 2024-02-28 at 9 15 39 AM Screen Shot 2024-02-28 at 9 15 43 AM Screen Shot 2024-02-28 at 9 15 47 AM Screen Shot 2024-02-28 at 9 15 50 AM Screen Shot 2024-02-28 at 9 15 54 AM

Re-use (new profile) existing cancelled (but still Active) credentials - PASSED

example example example example example example
Screen Shot 2024-02-28 at 9 25 06 AM Screen Shot 2024-02-28 at 9 25 24 AM Screen Shot 2024-02-28 at 9 25 47 AM Screen Shot 2024-02-28 at 9 25 57 AM Screen Shot 2024-02-28 at 9 26 02 AM Screen Shot 2024-02-28 at 9 26 06 AM

@stephendonner stephendonner added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment