Skip to content

Crash when completing checkout of any Premium product on account.bravesoftware.com #36246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephendonner opened this issue Feb 21, 2024 · 9 comments

Comments

@stephendonner
Copy link

stephendonner commented Feb 21, 2024

Description

Crash when completing checkout of any Premium product on account.bravesoftware.com

Found while testing #35933 for uplift

Steps to Reproduce

  1. install 1.65.19
  2. launch Brave using --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev
  3. load account.bravesoftware.com
  4. click Buy now for Leo Premium or Brave VPN (or Brave Talk)
  5. finish Stripe checkout using test credit-card details

Actual result:

Out-of-memory (OOM) crasher (just a bunch of near-useless registers/offsets, to me):

[ 00 ] RaiseException
[ 01 ] 0x7ffbcda7c3f2
[ 02 ] 0x7ffbcb2523a9
[ 03 ] 0x7ffbd1872a78
[ 04 ] 0x7ffbcda7c415
[ 05 ] 0x7ffbce3a0b60
[ 06 ] 0x7ffbd3190c08
[ 07 ] 0x7ffbc9d2294a
[ 08 ] 0x7ffbd17a7260
[ 09 ] 0x7ffbce16cf4c
[ 10 ] 0x7ffbd318f7c0
[ 11 ] 0x7ffbd3190c08
[ 12 ] 0x7ffbd318f800
[ 13 ] 0x7ffbc9d20de1
[ 14 ] 0x7ffbcad99f00
[ 15 ] 0x7ffbd302df40
[ 16 ] 0x7ffbcad99f00
[ 17 ] 0x7ffbd302df40
[ 18 ] 0x7ffbca6da2cc
[ 19 ] 0x7ffbc9d20ca3
[ 20 ] 0x7ffbcb19c503
[ 21 ] 0x7ffbcaa9914b
[ 22 ] 0x7ffbcad99f00
[ 23 ] 0x7ffbd302df40
[ 24 ] 0x7ffbd264ab8e
[ 25 ] 0x7ffbd29fccd3
[ 26 ] 0x7ffbc541eb62
[ 27 ] 0x7ffbd264ab8e
[ 28 ] 0x7ffbd29fccd3
[ 29 ] 0x7ffbc541eb62
[ 30 ] 0x7ffbd264ab8e
[ 31 ] 0x7ffbd29fccd3
[ 32 ] 0x7ffbc541eb62
[ 33 ] 0x7ffbd264ab8e
[ 34 ] 0x7ffbd29fccd3
[ 35 ] 0x7ffbc541eb62
[ 36 ] 0x7ffbcb163200
[ 37 ] 0x7ffbca6da314
[ 38 ] 0x7ffbd264ab8e
[ 39 ] 0x7ffbd29fccd3
[ 40 ] 0x7ffbc541eb62
[ 41 ] 0x7ffbcb163200
[ 42 ] 0x7ffbcb16053c
[ 43 ] 0x7ffbcb163200
[ 44 ] 0x7ffbcb19c503
[ 45 ] 0x7ffbc6b8d776
[ 46 ] 0x7ffbc541eb78
[ 47 ] 0x7ffbd264ab8e
[ 48 ] 0x7ffbd29fccd3
[ 49 ] 0x7ffbc541eb62
[ 50 ] 0x7ffbc541e774
[ 51 ] 0x7ffbc59c5a2a
[ 52 ] 0x7ffbd31a001c
[ 53 ] 0x7ffbd29fccb9
[ 54 ] 0x7ffbd18709c8
[ 55 ] 0x7ffbc59c5451
[ 56 ] 0x7ffbca6da314
[ 57 ] 0x7ffbd18726f8
[ 58 ] 0x7ffbd18709c8
[ 59 ] 0x7ffbd1f8b430
[ 60 ] 0x7ffbd29fccb9
[ 61 ] 0x7ffbd304b8c8
[ 62 ] 0x7ffbcafa5c82
[ 63 ] 0x7ffbcb03903a
[ 64 ] 0x7ffbc9e1c880
[ 65 ] 0x7ffbcaa48e29

Expected result:

image

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.65.19 Chromium: 122.0.6261.43 (Official Build) nightly (64-bit)
-- | --
Revision | 72b5648225a33e7604764c462fa76dec1ea961ca
OS | Windows 10 Version 22H2 (Build 19045.4046)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

cc @bbondy @mattmcalister @nvonpentz @brave/qa-team

@stephendonner
Copy link
Author

No crash using

Brave | 1.65.18 Chromium: 122.0.6261.43 (Official Build) nightly (64-bit)
-- | --
Revision | 0a30e212ac8b249a4c378de87aff9795daaa8a49
OS | Windows 10 Version 22H2 (Build 19045.4046)

@stephendonner
Copy link
Author

Just noticed brave/brave-core#22169, which may help with this. I'll grab the next build and see.

@nvonpentz
Copy link

nvonpentz commented Feb 21, 2024

Yes brave/brave-core#22169 may fix

@stephendonner
Copy link
Author

Yes brave/brave-core#22169 may fix

For posterity, crashes continued with 1.65.22, an example of which is 6b0c0000-b651-8c0b-0000-000000000000

@nvonpentz
Copy link

Fixed via brave/brave-core#22218

@kjozwiak
Copy link
Member

@MadhaviSeelam @stephendonner moved the issue into https://github.com/brave/brave-browser/milestone/468 as brave/brave-core#22109 should resolve the crash 👍 This will get verified by default while running through #35933 but lets double check/ensure that it's not crashing. Can cross reference your verifications from #35933.

@MadhaviSeelam
Copy link

Verified the issue as part of #35933 (comment) on Win 11 x64. Confirmed no crash happened while completing checkout of premium products and loaded credentials successfully on account.bravesoftware.com

Brave | 1.63.164 Chromium: 122.0.6261.69 (Official Build) (64-bit)
-- | --
Revision | 0a640ded5b59268307d1ae11b74646763cb82b4c
OS | Windows 11 Version 23H2 (Build 22631.3155)

@stephendonner
Copy link
Author

stephendonner commented Feb 28, 2024

Linux verified via #35933 (comment).

using

Brave	1.63.165 Chromium: 122.0.6261.94 (Official Build) (64-bit) 
Revision	fed0fcc915f6d9e1db871202f0304c8d582a73de
OS	Linux

@stephendonner
Copy link
Author

stephendonner commented Feb 28, 2024

macOS verified via #35933 (comment).

using

Brave | 1.63.164 Chromium: 122.0.6261.69 (Official Build) (x86_64)
-- | --
Revision | 0a640ded5b59268307d1ae11b74646763cb82b4c
OS | macOS Version 11.7.10 (Build 20G1427)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment