Skip to content

Remove old adblock components after installing new ones #22270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#36310

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@antonok-edm antonok-edm self-assigned this Feb 22, 2024
component_path_ = path;

NotifyObservers(engine_is_default_);

if (!old_path.empty()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the new adblock engine loaded at this point so nothing will read from the old one? I don't think posting a delayed task is a good way to deal deal with this if it's not

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, the new path exists on disk and is used for future loads of the adblock engine. None of the on-disk contents of the directory are referenced by the engine after the initial load, just whatever's in-memory.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought some files were read at runtime, but it sounds like that isn't the case so just make this BEST_EFFORT task priority

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@antonok-edm antonok-edm force-pushed the remove-old-adblock-components branch from 0ee51f6 to 5352f25 Compare February 22, 2024 21:26
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once post delayed task is replaced by low task priority

@antonok-edm antonok-edm force-pushed the remove-old-adblock-components branch from 5352f25 to 97d33dc Compare February 22, 2024 21:27
@antonok-edm antonok-edm merged commit 5cc5919 into master Feb 23, 2024
@antonok-edm antonok-edm deleted the remove-old-adblock-components branch February 23, 2024 01:46
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old adblock components remain on-disk until browser is closed
2 participants