-
Notifications
You must be signed in to change notification settings - Fork 966
Remove old adblock components after installing new ones #22270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
component_path_ = path; | ||
|
||
NotifyObservers(engine_is_default_); | ||
|
||
if (!old_path.empty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the new adblock engine loaded at this point so nothing will read from the old one? I don't think posting a delayed task is a good way to deal deal with this if it's not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, the new path exists on disk and is used for future loads of the adblock engine. None of the on-disk contents of the directory are referenced by the engine after the initial load, just whatever's in-memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought some files were read at runtime, but it sounds like that isn't the case so just make this BEST_EFFORT task priority
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
0ee51f6
to
5352f25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once post delayed task is replaced by low task priority
5352f25
to
97d33dc
Compare
Resolves brave/brave-browser#36310
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: