Skip to content

Old adblock components remain on-disk until browser is closed #36310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
antonok-edm opened this issue Feb 22, 2024 · 0 comments · Fixed by brave/brave-core#22270
Closed

Old adblock components remain on-disk until browser is closed #36310

antonok-edm opened this issue Feb 22, 2024 · 0 comments · Fixed by brave/brave-core#22270
Assignees
@antonok-edm
Labels
enhancement feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include
Milestone
1.65.x - Release

Comments

@antonok-edm
Copy link
Collaborator

Adblock component updates can be fairly large (currently around 5.4MB). Right now, the entire adblock list is extracted on-disk, for every new component version, until the browser is closed, at which point older versions are cleared.

There's no reason to keep the older versions around once a new version is available, so we should delete them whenever receiving an update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
enhancement feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include
Projects
None yet
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

Remove old adblock components after installing new ones brave/brave-core
2 participants
@antonok-edm @brave-builds