Skip to content

Fix Tipping conversion, editText hint, not enough warning (uplift to 1.53.x) #18899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix Tipping conversion, editText hint, not enough warning (uplift to 1.53.x) #18899

merged 1 commit into from
Jun 16, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 14, 2023 •
edited by kjozwiak
Loading

Uplift of #18841
Resolves brave/brave-browser#30907
Resolves brave/brave-browser#30908
Resolves brave/brave-browser#30909
Resolves brave/brave-browser#30910
Resolves brave/brave-browser#30911

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner June 14, 2023 05:40
@brave-builds brave-builds self-assigned this Jun 14, 2023
@brave-builds brave-builds added this to the 1.53.x - Beta milestone Jun 14, 2023
kjozwiak
kjozwiak approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.53.x approved 👍 QA has verified the PR on Nightly as per #18841 (comment).

@kjozwiak kjozwiak merged commit d22d407 into 1.53.x Jun 16, 2023
@kjozwiak kjozwiak deleted the pr18841_30907_fix_tipping_issues_1.53.x branch June 16, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak