Skip to content

Unable to empty or make the custom tip value to 0.0 always 5 BAT is displayed in the text box #30908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeetaSarvadnya opened this issue Jun 8, 2023 · 3 comments · Fixed by brave/brave-core#18841
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #30907
Unable to empty or make the custom tip value to 0.0 always 5 BAT is displayed in the text box

Steps to reproduce

Case 1:

  1. Clean profile 1.53.x
  2. Enable rewards and connect uphold custodian
  3. Open the uphold verified creator laurenwags.github.io
  4. Open the tipping banner and click on the Custom
  5. Put cursor on the 0.0 BAT textbox
  6. Use backspace to remove 0.0 BAT
  7. Always 5 BAT is shown in the textbox

Case 2:

  1. Clean profile 1.53.x
  2. Enable rewards and connect uphold custodian
  3. Open the uphold verified creator laurenwags.github.io
  4. Open the tipping banner and select any default tip amount (e.g 10.5)
  5. Click on the Custom
  6. Put cursor on the 10.5 BAT textbox
  7. Use backspace to remove 10.5 BAT
  8. Always 5 BAT is shown in the textbox after removing 10.5 BAT

Actual result

Unable to empty or make the custom tip value to 0.0 always 5 BAT is displayed in the text box
image

Expected result

should work same as Desktop

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): all
  • Device type (Phone, Tablet, Phablet): all
  • Android version: 12

Brave version

1.53.83

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @Miyayes @deeppandya @sujitacharya2005

@sujitacharya2005
Copy link

brave/brave-core#18841

@kjozwiak
Copy link
Member

The above requires 1.53.96 or higher for 1.53.x verification 👍

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jun 19, 2023

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.53.99

  • Verified the cases from the description
  • Confirmed that custom tip value can be removed/emptied completely
  • Confirmed that default value 5 is not shown in the custom tip text field
vidma_recorder_19062023_133743.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants