-
Notifications
You must be signed in to change notification settings - Fork 965
Make all four corners of the Contribution Banner 3.0 rounded #18487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ee2821c
to
e07badc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified with
Issue 1 - brave/brave-browser/issues/30331 - PASSED
![]() Issue 2 - brave/brave-browser/issues/30489 - PASSEDConfirmed all 4 corners of contribution (tip) banner are rounded:
|
Verified with
Issue 2 - brave/brave-browser/issues/30489 - PASSEDConfirmed all 4 corners of contribution (tip) banner are rounded:
|
Verified with
Issue 2 - brave/brave-browser/issues/30489 - PASSEDConfirmed all 4 corners of contribution (tip) banner are rounded:
|
Resolves brave/brave-browser#30282Resolves brave/brave-browser#30331
Resolves brave/brave-browser#30489
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: