Skip to content

Make all four corners of the Contribution Banner 3.0 rounded #18487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2023

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented May 15, 2023

Resolves brave/brave-browser#30282
Resolves brave/brave-browser#30331
Resolves brave/brave-browser#30489

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing requested a review from a team as a code owner May 15, 2023 20:40
@zenparsing zenparsing requested a review from a team May 15, 2023 20:40
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing force-pushed the ksmith-tip-panel-corners branch from ee2821c to e07badc Compare May 15, 2023 21:14
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurenWags
Copy link
Member

LaurenWags commented May 22, 2023

Verified with

Brave | 1.53.60 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64)
-- | --
Revision | 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS | macOS Version 13.4 (Build 22F66)
Issue 1 - brave/brave-browser/issues/30331 - PASSED
  1. Be logged in to twitter
  2. Have rewards enabled and connected to a custodian
  3. Navigate to a creator who is verified with same custodian as you
  4. Make a contribution
  5. On success banner, select "Share your support"
  6. View pre-canned tweet on twitter
    --> Confirmed addition of "BAT" to pre-canned tweet:
tweet
Issue 2 - brave/brave-browser/issues/30489 - PASSED

Confirmed all 4 corners of contribution (tip) banner are rounded:

Dark Light
1 2

@Miyayes Miyayes changed the title Make all four corners of the tip panel rounded Make all four corners of the Contribution Banner 3.0 rounded May 22, 2023
@LaurenWags
Copy link
Member

Verified with

Brave	1.53.60 Chromium: 114.0.5735.26 (Official Build) nightly (64-bit) 
Revision	7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS	Windows 10 Version 21H2 (Build 19044.2965)
Issue 2 - brave/brave-browser/issues/30489 - PASSED

Confirmed all 4 corners of contribution (tip) banner are rounded:

Dark Light
1 2

@LaurenWags
Copy link
Member

LaurenWags commented May 22, 2023

Verified with

Brave	1.53.60 Chromium: 114.0.5735.26 (Official Build) nightly (64-bit) 
Revision	7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS	Linux
Issue 2 - brave/brave-browser/issues/30489 - PASSED

Confirmed all 4 corners of contribution (tip) banner are rounded:

Dark Light
1 2

kjozwiak pushed a commit that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants