Skip to content

bottom corners on contribution/tip banner are rounded and square simultaneously - follow up to 30282 #30463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LaurenWags opened this issue May 19, 2023 · 6 comments · Fixed by brave/brave-core#18551

Comments

@LaurenWags
Copy link
Member

Description

After brave/brave-core#18487 landed in Nightly, still seeing issue as described in #30282

Steps to Reproduce

  1. Clean profile 1.52.x or 1.53.x
  2. Close/relaunch to pull griffin
  3. Enable Rewards, connect a custodian (I used Uphold)
  4. Open a new tab and navigate to laurenwags.github.io
  5. Open tip banner for site, bottom rounded corners look fine
  6. Open a new tab, do not re-use same tab
  7. Open alexvincentmusic.com
  8. Open tip banner for site --> bottom corners are rounded and square

Reproduced with both light and dark themes.

Actual result:

Dark Light
1 2

Expected result:

rounded corners only

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.53.52 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64)
-- | --
Revision | 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS | macOS Version 13.3.1 (a) (Build 22E772610a)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? per original issue, yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @zenparsing

@GeetaSarvadnya
Copy link

Reproduced the issue, In windows only the bottom corners are rounded - Windows 10 x64 - 1.52.102

Light Dark
image image

@kjozwiak
Copy link
Member

The above requires 1.52.110 or higher for 1.52.x verification 👍

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 24, 2023
@LaurenWags
Copy link
Member Author

LaurenWags commented May 24, 2023

Verified with

Brave | 1.52.110 Chromium: 114.0.5735.35 (Official Build) (x86_64)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | macOS Version 13.4 (Build 22F66)

Verified STR from #30463 (comment):

  1. Clean profile 1.52.x
  2. Close/relaunch to pull griffin
  3. Enable Rewards, connect a custodian (I used Uphold)
  4. Open a new tab and navigate to laurenwags.github.io
  5. Open tip banner for site, bottom rounded corners look fine
  6. Open a new tab, do not re-use same tab
  7. Open alexvincentmusic.com
  8. Open tip banner for site
    ---> Confirmed bottom corners were rounded - no artifacts making corners appear rounded and square as in the image in issue description
Step 5 Step 8
5 8

Repeated above test using light theme as well (fresh profile):

Step 5 Step 8
5 8

Generally visited various verified creators and confirmed the bottom corners of the contribution banners were rounded as expected using both light and dark themes:

Example Example Example Example
1 2 3 4

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 24, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.52.110 Chromium: 114.0.5735.35 (Official Build) (64-bit)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Verified STR from #30463 (comment):

  1. Clean profile 1.52.x
  2. Close/relaunch to pull griffin
  3. Enable Rewards, connect a custodian (I used Uphold)
  4. Open a new tab and navigate to laurenwags.github.io
  5. Open tip banner for site, bottom rounded corners look fine
  6. Open a new tab, do not re-use same tab
  7. Open alexvincentmusic.com
  8. Open tip banner for site
    ---> Confirmed bottom corners were rounded - no artifacts making corners appear rounded and square as in the image in issue description
Step 5 Step 8
image image

Repeated above test using light theme as well (fresh profile):

Step 5 Step 8
image image

Generally visited various verified creators and confirmed the bottom corners of the contribution banners were rounded as expected using both light and dark themes:

Example Example Example Example
image image image image

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.52.112 Chromium: 114.0.5735.35 (Official Build) (64-bit)
-- | --
Revision | 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS | Windows 10 Version 22H2 (Build 19045.2965)

Verified STR from #30463 (comment):

  1. Clean profile 1.52.x
  2. Close/relaunch to pull griffin
  3. Enable Rewards, connect a custodian (I used Uphold)
  4. Open a new tab and navigate to laurenwags.github.io
  5. Open tip banner for site, bottom rounded corners look fine
  6. Open a new tab, do not re-use same tab
  7. Open alexvincentmusic.com
  8. Open tip banner for site
    ---> Confirmed bottom corners were rounded - no artifacts making corners appear rounded and square as in the image in issue description
Step 5 Step 8
image image

Repeated above test using Dark theme as well (fresh profile):

Step 5 Step 8
image image

Generally visited various verified creators and confirmed the bottom corners of the contribution banners were rounded as expected using both light and dark themes:

Example Example Example Example
image image image Uploading image.png…

@btlechowski
Copy link

Verification passed on

Brave 1.52.112 Chromium: 114.0.5735.35 (Official Build) (64-bit)
Revision 2295354895fa3652ae47b651481831484f16d1ff-refs/branch-heads/5735@{#713}
OS Ubuntu 18.04 LTS

Verified STR from #30463 (comment):

  1. Clean profile 1.52.x
  2. Close/relaunch to pull griffin
  3. Enable Rewards, connect a custodian (I used Uphold)
  4. Open a new tab and navigate to laurenwags.github.io
  5. Open tip banner for site, bottom rounded corners look fine
  6. Open a new tab, do not re-use same tab
  7. Open alexvincentmusic.com
  8. Open tip banner for site
    ---> Confirmed bottom corners were rounded - no artifacts making corners appear rounded and square as in the image in issue description

image

Repeated above test using Dark theme as well (fresh profile):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment