-
Notifications
You must be signed in to change notification settings - Fork 966
Sync ephemeral and first party storage cleanup #18331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aee2b89
to
5c12c1e
Compare
60a276f
to
ee5e1f6
Compare
iefremov
reviewed
May 30, 2023
iefremov
reviewed
Jun 6, 2023
namespace permissions { | ||
class PermissionLifetimeManagerBrowserTest; | ||
} | ||
|
||
namespace ephemeral_storage { | ||
|
||
// Service to enable or disable first party ephemeral storage from external |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not only "first party" now?
iefremov
approved these changes
Jun 6, 2023
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/run-network-audit
Run network-audit
CI/run-upstream-tests
Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
TLDEphemeralLifetime
intoEphemeralStorageService
.BraveEphemeralStorageServiceDelegate
which is now located in//brave/browser
. This allows us to cleanup//chrome
-declared bits.FirstPartyStorageLifetime
asTLDEphemeralLifetime
now triggers the cleanup event for both EphemeralStorage and ForgetFirstPartyByDefault features.Resolves brave/brave-browser#30090
Resolves brave/brave-browser#30330
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Per discussion via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1687362687017369?thread_ts=1680615454.570509&cid=CHGKGMHDJ, the test plan for this one is: