-
Notifications
You must be signed in to change notification settings - Fork 2.6k
"Forget By Default" feature #26465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@kjozwiak the core part we're about to enable in Adds a new option to the cookie block policy dropdown in Shields popup and on When this option is selected, website data (cookies, storages) will be removed after 30 seconds the website is closed. |
@brave/qa-team this should be tested at the same time as #30090 / brave/brave-core#18331 since the test plan is the same. Confirmed via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1687415361386809?thread_ts=1680615454.570509&cid=CHGKGMHDJ. |
Verification
Case 1 - Before feature being enabled via Griffin -
|
step 3 | step 5 | step 6 |
---|---|---|
![]() |
![]() |
![]() |
Case 2: After feature being enabled via Griffin - PASSED
- continue from Case 1:
BraveForgetFirstPartyStorage
isn't visible underbrave://version
Forget me when I close this site
toggle doesn't appear viabrave://settings/shields
- closed and restarted Brave
- confirmed
BraveForgetFirstPartyStorage:Enabled
is shown inbrave://version
- opened Shields panel in the nytimes.com tab
- opened brave://settings/shields
- Confirmed
Forget me when I close this site
toggle appears in the Shields panel and isOff
by default - Confirmed
Forget me when I close this site
toggle appears in thebrave://settings/shields
and isOff
by default
step 3 | step 4 | step 5 |
---|---|---|
![]() |
![]() |
![]() |
Dark theme
shields panel | brave://settings/shields |
---|---|
![]() |
![]() |
Note: In-depth testing has been done via #30090 (comment) (Test Case 1 - Test Case 2)
Verification
Case 1 - Before feature being enabled via Griffin -
|
step 3 | step 5 | step 6 |
---|---|---|
![]() |
![]() |
![]() |
Case 2: After feature being enabled via Griffin - PASSED
- continue from Case 1:
BraveForgetFirstPartyStorage
isn't visible underbrave://version
Forget me when I close this site
toggle doesn't appear viabrave://settings/shields
- closed and restarted Brave
- confirmed
BraveForgetFirstPartyStorage:Enabled
is shown inbrave://version
- opened Shields panel in the nytimes.com tab
- opened brave://settings/shields
- Confirmed
Forget me when I close this site
toggle appears in the Shields panel and isOff
by default - Confirmed
Forget me when I close this site
toggle appears in thebrave://settings/shields
and isOff
by default
step 3 | step 4 | step 5 |
---|---|---|
![]() |
![]() |
![]() |
Dark theme
shields panel | brave://settings/shields |
---|---|
![]() |
![]() |
Note: Verified the UI for for Forget me when I close this site
mainly. The toggle is available in the Shields panel & in brave://settings/sheids
. UI matches to the screenshots mentioned #26465 (comment). Forget me when I close this site
functionality works as expected and In-depth testing is done via 30090
Verification
|
step 3 | step 5 | step 6 |
---|---|---|
![]() |
![]() |
![]() |
Case 2: After feature being enabled via Griffin - PASSED
- continue from Case 1:
BraveForgetFirstPartyStorage
isn't visible underbrave://version
Forget me when I close this site
toggle doesn't appear viabrave://settings/shields
- closed and restarted Brave
- confirmed
BraveForgetFirstPartyStorage:Enabled
is shown inbrave://version
- opened Shields panel in the
brave.com
tab - opened
brave://settings/shields
- Confirmed
Forget me when I close this site
toggle appears in the Shields panel and isOff
by default - Confirmed
Forget me when I close this site
toggle appears in thebrave://settings/shields
and isOff
by default
step 3 | step 4 | step 5 |
---|---|---|
![]() |
![]() |
![]() |
Dark theme
Shields panel | brave://settings/shields |
---|---|
![]() |
![]() |
Note: Verified the UI for for Forget me when I close this site
mainly. The toggle is available in the Shields panel & in brave://settings/sheids
. UI matches to the screenshots mentioned #26465 (comment). Forget me when I close this site
functionality works as expected and In-depth testing is done via 30090
Verified with
Case 1 - Before feature being enabled via Griffin -
|
step 3 | step 5 | step 6 |
---|---|---|
![]() |
![]() |
![]() |
Case 2: After feature being enabled via Griffin - PASSED
- continue from Case 1:
BraveForgetFirstPartyStorage
isn't visible underbrave://version
Forget me when I close this site
toggle doesn't appear viabrave://settings/shields
- closed and restarted Brave
- confirmed
BraveForgetFirstPartyStorage:Enabled
is shown inbrave://version
- opened Shields panel in the
brave.com
tab - opened
brave://settings/shields
- Confirmed
Forget me when I close this site
toggle appears in the Shields panel and isOff
by default - Confirmed
Forget me when I close this site
toggle appears in thebrave://settings/shields
and isOff
by default
step 3 | step 4 | step 5 |
---|---|---|
![]() |
![]() |
![]() |
Dark theme
Shields panel | brave://settings/shields |
---|---|
![]() |
![]() |
Note: Verified the UI for for Forget me when I close this site
mainly. The toggle is available in the Shields panel & in brave://settings/sheids
. UI matches to the screenshots mentioned #26465 (comment). Forget me when I close this site
functionality works as expected and In-depth testing is done via #30090 (comment).
Verified on
Test Case - Enabling BraveForgetFirstPartyStorage in brave://flags
Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site/wait 30s) Ensure that BraveForgetFirstPartyStorage:Enabled via brave://flags
Test Case - Enabling BraveForgetFirstPartyStorage (Re-opening website within ~30s)
Test Case - Enabling BraveForgetFirstPartyStorage (Permissions)
Test Case - Enabling BraveForgetFirstPartyStorage (Feature enabled/disabled shields)
Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings)
Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings and disabling per website)
Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site via Private/Incognito)
As mentioned at the beginning of the issue, the following runs through Test Case from #30090 (comment)
Test Case from #30090 (comment)
|
Verified on
Test Case - Enabling BraveForgetFirstPartyStorage in brave://flags
Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site/wait 30s) Ensure that BraveForgetFirstPartyStorage:Enabled via brave://flags
Test Case - Enabling BraveForgetFirstPartyStorage (Re-opening website within ~30s)
Test Case - Enabling BraveForgetFirstPartyStorage (Permissions)
Test Case - Enabling BraveForgetFirstPartyStorage (Feature enabled/disabled shields)
Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings)
Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings and disabling per website)
Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site via Private/Incognito)
As mentioned at the beginning of the issue, the following runs through Test Case from #30090 (comment)
Test Case from #30090 (comment)
|
Verified on
Test Case - Enabling BraveForgetFirstPartyStorage in brave://flags
Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site/wait 30s) Ensure that BraveForgetFirstPartyStorage:Enabled via brave://flags
Test Case - Enabling BraveForgetFirstPartyStorage (Re-opening website within ~30s)
Test Case - Enabling BraveForgetFirstPartyStorage (Permissions)
Test Case - Enabling BraveForgetFirstPartyStorage (Feature enabled/disabled shields)
Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings)
Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings and disabling per website)
Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site via Private/Incognito)
As mentioned at the beginning of the issue, the following runs through Test Case from #30090 (comment)
Test Case from #30090 (comment)
|
See #32311 |
Spec is available in #specs in Slack: https://bravesoftware.slack.com/archives/CELA35G5S/p1666392931428619
Current state (1.54.x)
FBD is implemented as a separate toggle in Brave Shields UI:
Screenshots
UI "nudge" part is moved here -> #31200
The text was updated successfully, but these errors were encountered: