-
Notifications
You must be signed in to change notification settings - Fork 981
Add P3A core usage ping metrics for daily & monthly cadences, create … #17649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iefremov
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
components/p3a lgtm
ee78988
to
6b4efac
Compare
darkdh
reviewed
Mar 31, 2023
darkdh
reviewed
Mar 31, 2023
6b4efac
to
0367c9e
Compare
darkdh
reviewed
Apr 4, 2023
0367c9e
to
1adf821
Compare
darkdh
reviewed
Apr 4, 2023
…new wallet ping metrics for all cadences
1adf821
to
04f1f26
Compare
darkdh
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…new wallet ping metrics for all cadences
Resolves brave/brave-browser#29122
Resolves brave/brave-browser#29123
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
For brave/brave-browser#29122:
Ensure
1
is sent forBrave.Core.UsageMonthly
andBrave.Core.UsageDaily
once for month/day.For brave/brave-browser#29123:
Ensure
1
is sent forBrave.Wallet.UsageMonthly
,Brave.Wallet.UsageWeekly
andBrave.Wallet.UsageDaily
when the wallet is unlocked. Advance the system time by one day/week/month, launch browser and ensure each metric has been deleted, depending on the cadence. Ensure the metrics appear and are sent again when the wallet is unlocked again.