Skip to content

Add P3A core usage ping metrics for daily & monthly cadences, create … #17649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

DJAndries
Copy link
Collaborator

…new wallet ping metrics for all cadences

Resolves brave/brave-browser#29122
Resolves brave/brave-browser#29123

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

For brave/brave-browser#29122:

Ensure 1 is sent for Brave.Core.UsageMonthly and Brave.Core.UsageDaily once for month/day.

For brave/brave-browser#29123:

Ensure 1 is sent for Brave.Wallet.UsageMonthly, Brave.Wallet.UsageWeekly and Brave.Wallet.UsageDaily when the wallet is unlocked. Advance the system time by one day/week/month, launch browser and ensure each metric has been deleted, depending on the cadence. Ensure the metrics appear and are sent again when the wallet is unlocked again.

Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components/p3a lgtm

@DJAndries DJAndries force-pushed the wallet-p3a-cadence-update branch from ee78988 to 6b4efac Compare March 31, 2023 22:05
@DJAndries DJAndries force-pushed the wallet-p3a-cadence-update branch from 6b4efac to 0367c9e Compare April 4, 2023 03:34
@DJAndries DJAndries requested a review from darkdh April 4, 2023 03:35
@DJAndries DJAndries force-pushed the wallet-p3a-cadence-update branch from 0367c9e to 1adf821 Compare April 4, 2023 18:50
@DJAndries DJAndries requested a review from darkdh April 4, 2023 18:50
@DJAndries DJAndries requested a review from darkdh April 4, 2023 20:23
@DJAndries DJAndries force-pushed the wallet-p3a-cadence-update branch from 1adf821 to 04f1f26 Compare April 4, 2023 20:23
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace wallet usage P3A metrics with new ones in proper cadences Add core usage ping metrics via P3A
3 participants