Skip to content

Add daily/monthly usage ping P3A metrics for iOS #36177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DJAndries opened this issue Feb 16, 2024 · 8 comments · Fixed by brave/brave-core#22386
Closed

Add daily/monthly usage ping P3A metrics for iOS #36177

DJAndries opened this issue Feb 16, 2024 · 8 comments · Fixed by brave/brave-core#22386
Assignees
Labels
feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) features/P3A OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude

Comments

@DJAndries
Copy link
Collaborator

Please replicate #29122. Please uplift to release once complete.

cc @brave/ios

@anthonypkeane
Copy link

anthonypkeane commented Feb 29, 2024

Would it be possible to uplift this to 1.63 @iccub

NVM, looks like it is being uplifted, thanks

@kjozwiak kjozwiak added the QA/Yes label Mar 2, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2024

@DJAndries @kylehickinson can we get some STR/Cases added for the above? Or is it the same cases as brave/brave-core#17649 (comment)? If that's the case, lets update the issue/PR to mention what needs to be checked/verified 👍

@kylehickinson
Copy link
Collaborator

kylehickinson commented Mar 4, 2024

@kjozwiak it should be the same as desktop, the main difference is that iOS isn't implementing the wallet-related usage P3A metrics directly, just Brave.Core.UsageMonthly and Brave.Core.UsageDaily (Added that part of the test plan to the PR)

@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2024

@DJAndries @kylehickinson do we need to update the Wiki with the above? I labelled this as Done but I guess that also includes updating the wiki so double checking just in case 👍

@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2024

The above requires 1.63.169 or higher for 1.63.x verification 👍

@kylehickinson
Copy link
Collaborator

This currently won't be verifiable on release because access to debug menus is not available there just fyi

@DJAndries
Copy link
Collaborator Author

@DJAndries @kylehickinson do we need to update the Wiki with the above? I labelled this as Done but I guess that also includes updating the wiki so double checking just in case 👍

updated the wiki 👍

@kjozwiak
Copy link
Member

kjozwiak commented Mar 6, 2024

This currently won't be verifiable on release because access to debug menus is not available there just fyi

@kylehickinson in that case, lets just QA/No this for the initial release. @DJAndries can keep an eye on the data/stats hitting the back-end once 1.63.x goes out. @GeetaSarvadnya did verify that it was working on Nightly via brave/brave-core#22386 (comment) before we uplifted into 1.64.x & 1.63.x.

@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Mar 6, 2024
@github-project-automation github-project-automation bot moved this to Done (wiki updated) in P3A Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) features/P3A OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
Status: Done (wiki updated)
Development

Successfully merging a pull request may close this issue.

5 participants