Launch what's new page at major version update #17593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
potential-layer-violation-fixes
simonhong
force-pushed
the
whats_new
branch
2 times, most recently
from
7aa2ced to
5d362b4
Compare
spylogsster
approved these changes
Mar 15, 2023
bridiver
reviewed
Jun 20, 2024
| void StartBraveWhatsNew(Browser* browser) { | ||
| constexpr char kBraveWhatsNewURL[] = "https://brave.com/whats-new/"; | ||
| // Load whats-new url in the first foreground tab. | ||
| chrome::AddTabAt(browser, GURL(kBraveWhatsNewURL), 0, true); |
There was a problem hiding this comment.
why does open the url directly instead of fetching it like chromium?
bridiver
reviewed
Jun 20, 2024
| } | ||
|
|
||
| void RegisterLocalStatePrefs(PrefRegistrySimple* registry) { | ||
| registry->RegisterDoublePref(prefs::kWhatsNewLastVersion, 0); |
There was a problem hiding this comment.
why are we creating our pref for this instead of using upstream kLastWhatsNewVersion?
bridiver
reviewed
Jun 20, 2024
| } | ||
|
|
||
| // Returns 1.xx or 2.xx as double. | ||
| absl::optional<double> GetCurrentBrowserVersion() { |
There was a problem hiding this comment.
why do we need all of this when the chromium code already does this on major version updates?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#28947
If griffin's target version is same with browser's current version,
browser will load whats-new url in the first foreground tab once per major version up.
Griffin will provide
target_major_versionparams - https://github.com/brave/brave-variations/pull/544/files#diff-7ac2945ede68c73330363911678f6c9a2a6290b70e2dd170868295f65da7e872R1842When
whats_new::ShouldShowBraveWhatsNewForState()returnstrue,chrome://whats-new/url is added to startup tabs list.For that loading that url, browser runs
whats_new::StartBraveWhatsNew()instead of loading it directly. And
whats_new::StartBraveWhatsNew()loadshttps://www.brave.com/whats-new/ in foreground first tab.
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
BraveWhatsNewTest.*BraveWhatsNewBrowserTest.*Manual test
Note: Maybe need some relaunching to
1.51as it need to get trial data from griffinNote:
brave.whats_new.last_versionkey in brave://local-state/ includes lastly shown whats-new version.