Do not open brave://welcome in guest windows #17577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
approved these changes
Mar 13, 2023
Comment on lines
+72
to
+73
| EXPECT_EQ("about:blank", active_contents()->GetVisibleURL().spec()); | ||
| EXPECT_EQ(1, browser()->tab_strip_model()->count()); |
There was a problem hiding this comment.
nit: these line can be deleted as we don't need to check normal window's state
Comment on lines
+81
to
+85
| EXPECT_STREQ("about:blank", | ||
| base::UTF16ToUTF8( | ||
| browser()->location_bar_model()->GetFormattedFullURL()) | ||
| .c_str()); | ||
| EXPECT_EQ(1, browser()->tab_strip_model()->count()); |
There was a problem hiding this comment.
Ah, do you want to check normal window is not affected?
If so, ignore my comments.
Co-authored-by: Simon Hong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#29012
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: