Do not open brave://welcome in guest windows (#17577)

* Do not open brave://welcome in guest windows

* Update browser/brave_scheme_load_browsertest.cc

Co-authored-by: Simon Hong <[email protected]>

---------

Co-authored-by: Simon Hong <[email protected]>

Author: spylogsster

browser/brave_scheme_load_browsertest.cc

@@ -16,6 +16,7 @@
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/omnibox/browser/location_bar_model.h"
+#include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/common/url_constants.h"
@@ -59,6 +60,31 @@ class BraveSchemeLoadBrowserTest : public InProcessBrowserTest,
     return WaitForLoadStop(active_contents());
   }
 
+  // Check loading |url| in guest window is not allowed for an url.
+  void TestURLIsNotLoadedInGuestWindow(const GURL& url) {
+    Browser* guest_browser = CreateGuestBrowser();
+    TabStripModel* guest_model = guest_browser->tab_strip_model();
+
+    // Check guest window has one blank tab.
+    EXPECT_EQ("about:blank",
+              guest_model->GetActiveWebContents()->GetVisibleURL().spec());
+    EXPECT_EQ(1, guest_model->count());
+    EXPECT_EQ("about:blank", active_contents()->GetVisibleURL().spec());
+    EXPECT_EQ(1, browser()->tab_strip_model()->count());
+    // Unable to navigate expected url.
+    EXPECT_FALSE(
+        content::NavigateToURL(guest_model->GetActiveWebContents(), url));
+    auto* entry = guest_model->GetActiveWebContents()
+                      ->GetController()
+                      .GetLastCommittedEntry();
+    EXPECT_EQ(entry->GetPageType(), content::PageType::PAGE_TYPE_ERROR);
+    EXPECT_STREQ("about:blank",
+                 base::UTF16ToUTF8(
+                     browser()->location_bar_model()->GetFormattedFullURL())
+                     .c_str());
+    EXPECT_EQ(1, browser()->tab_strip_model()->count());
+  }
+
   // Check loading |url| in private window is redirected to normal
   // window.
   void TestURLIsNotLoadedInPrivateWindow(const std::string& url) {
@@ -260,3 +286,8 @@ IN_PROC_BROWSER_TEST_F(BraveSchemeLoadBrowserTest,
                        BraveWelcomePageIsNotAllowedInPrivateWindow) {
   TestURLIsNotLoadedInPrivateWindow("brave://welcome");
 }
+
+IN_PROC_BROWSER_TEST_F(BraveSchemeLoadBrowserTest,
+                       BraveWelcomePageIsNotAllowedInGuestWindow) {
+  TestURLIsNotLoadedInGuestWindow(GURL("brave://welcome"));
+}

browser/ui/webui/brave_web_ui_controller_factory.cc

@@ -146,7 +146,7 @@ WebUIController* NewWebUI(WebUI* web_ui, const GURL& url) {
     return new RewardsPanelUI(web_ui);
 #endif  // !BUILDFLAG(IS_ANDROID)
 #if !BUILDFLAG(IS_ANDROID)
-  } else if (host == kWelcomeHost) {
+  } else if (host == kWelcomeHost && !profile->IsGuestSession()) {
     return new BraveWelcomeUI(web_ui, url.host());
   } else if (host == chrome::kChromeUISettingsHost) {
     return new BraveSettingsUI(web_ui, url.host());