Skip to content

Use Brave-specific identifiers for MPRIS #17440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Mar 2, 2023

Fixes brave/brave-browser#16187

To be compliant with the MPRIS specification, we need to use a unique service name and not re-use Chromium's one.

The Track ID is defined in the same spec.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Dowload the shell script at https://gitlab.com/axdsop/nix-dotfiles/-/blob/master/Configs/polybar/scripts/mpris_player/mpris_player_control
  2. Start Brave and start playing this YouTube video.
  3. Run these commands and confirm the output matches this:
$ bash ./mpris_player_control -l
brave.instance1211788
$ bash ./mpris_player_control -c
Playing
Brave

Note: the instance number is random and instead of "Brave", you might see "Brave Browser" or something similar.

@fmarier fmarier requested a review from a team as a code owner March 2, 2023 00:52
@fmarier fmarier self-assigned this Mar 2, 2023
@fmarier fmarier force-pushed the mpris-service-name-16187 branch from cc5fb76 to b3c5f85 Compare March 2, 2023 04:06
@fmarier fmarier changed the title Use a Brave-specific identifier for mpris Use Brave-specific identifiers for MPRIS Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show media notifications for player controls (Linux)
2 participants