Skip to content

Show media notifications for player controls (Linux) #16187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
therealsujitk opened this issue Jun 2, 2021 · 3 comments · Fixed by brave/brave-browser-snap#19 or brave/brave-core#17440
Closed

Show media notifications for player controls (Linux) #16187

therealsujitk opened this issue Jun 2, 2021 · 3 comments · Fixed by brave/brave-browser-snap#19 or brave/brave-core#17440
Assignees
@fmarier
Labels
OS/Desktop OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@therealsujitk
Copy link

Description

It would be convenient to have a notification with media buttons whenever a video or an audio track is being played in the browser. That way it would be possible to control the player from the notification menu while using another application rather than switching to Brave every time.

Preview

Screenshot from 2021-06-02 09-58-52

Brave version (brave://version info)

Brave 1.25.68 Chromium: 91.0.4472.77 (Official Build) (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Linux
@therealsujitk
Copy link
Author

@bridiver, this issue only occurs in the linux snap build, can you add the OS/Linux/snap label to this issue?

@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion labels Oct 28, 2021
@jayschwa jayschwa mentioned this issue Jan 12, 2023
Merged
jayschwa added a commit to jayschwa/brave-browser-snap that referenced this issue Jan 12, 2023
@jayschwa
Fix mpris slot name
c1bb832 
MPRIS enables desktop environments (e.g. GNOME) to provide media player
controls for media playing in the browser.

Brave uses DBus name `org.mpris.MediaPlayer2.chromium` whereas Snap sets
an AppArmor rule for `org.mpris.MediaPlayer2.brave` by default. Setting
the name parameter explicitly for the slot makes Snap generate a
compatible AppArmor rule.

Fixes brave/brave-browser#16187
jayschwa added a commit to jayschwa/brave-browser-snap that referenced this issue Feb 9, 2023
@jayschwa
Fix mpris slot name
b1daad0 
MPRIS enables desktop environments (e.g. GNOME) to provide media player
controls for media playing in the browser.

Brave uses DBus name `org.mpris.MediaPlayer2.chromium` whereas Snap sets
an AppArmor rule for `org.mpris.MediaPlayer2.brave` by default. Setting
the name parameter explicitly for the slot makes Snap generate a
compatible AppArmor rule.

Fixes brave/brave-browser#16187
@fmarier fmarier self-assigned this Mar 1, 2023
@fmarier
Copy link
Member

fmarier commented Mar 1, 2023

We added a work-around in brave/brave-browser-snap#19, but the real fix is to expose the correct service name instead of org.mpris.MediaPlayer2.chromium in https://source.chromium.org/chromium/chromium/src/+/main:components/system_media_controls/linux/system_media_controls_linux.cc;l=54;drc=12be03159fe22cd4ef291e9561762531c2589539

@fmarier fmarier reopened this Mar 1, 2023
@wknapik wknapik mentioned this issue Mar 1, 2023
Merged
@fmarier fmarier mentioned this issue Mar 2, 2023
Merged
25 tasks
fmarier added a commit to brave/brave-core that referenced this issue Mar 2, 2023
@fmarier
Use a Brave-specific identifier for mpris (fixes brave/brave-browser#…
b3c5f85 
…16187)
@fmarier fmarier added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Mar 2, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 2, 2023
@rebron rebron changed the title Media Notifications [Feature Request] Show media notifications for player controls (Linux) Apr 4, 2023
@btlechowski
Copy link

Verification passed on

Brave 1.51.98 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS Ubuntu 22.04 LTS

Verified controls are shown when playing youtube video:
image

Verified playlist on youtube is supported
image

Verified controls are shown when playing rumble video:
image

Verified test plan from brave/brave-core#17440
./mpris_player_control -l
image
./mpris_player_control -c
image

@LaurenWags LaurenWags mentioned this issue May 1, 2023
Closed
@Malom-ctrl Malom-ctrl mentioned this issue May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Desktop OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/include
Projects
None yet
Milestone
1.51.x - Release
6 participants
@bridiver @fmarier @rebron @btlechowski @brave-builds @therealsujitk