Skip to content

Remove search onboarding from In #17316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#28656

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 21, 2023
@deeppandya deeppandya added this to the 1.50.x - Nightly milestone Feb 21, 2023
@deeppandya deeppandya self-assigned this Feb 21, 2023
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya merged commit 723d540 into master Feb 22, 2023
@deeppandya deeppandya deleted the remove_search_onboarding_in_android branch February 22, 2023 10:20
brave-builds added a commit that referenced this pull request Feb 22, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2023

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.50.75 Chromium: 111.0.5563.41 (Official Build) canary (32-bit)
--- | ---
Revision | 976ef12907ef9b413c2d929c043307b415d27b9e-refs/branch-heads/5563@{#737}
OS | Android 13; Build/TQ1A.230205.002

Basically ensured that tapping on the URL bar on a clean install didn't launch the SE onboarding like we're currently doing with 1.48.x. Went through the following:

Test Case #1 - India

  • changed the device locale/language to India
  • installed/launched 1.50.75 Chromium: 111.0.5563.41
  • tapped on the URL and ensured that Brave Widgets was the first onboarding that appeared
  • ensured that tapping on the omnibox the second time around didn't launch the SE onboarding
  • ensured that there's no SE onboarding when tapping on the omnibox after several restarts
  • ensured that Brave was selected as the default SE for both Normal and Private windows/tabs
screen-20230301-133622.mp4
Example Example Example Example
Screenshot_20230301-133309 Screenshot_20230301-133633 Screenshot_20230301-133641 Screenshot_20230301-133637

Test Case #2 - Other Locales that have SE onboarding (Japan & Russua)

  • changed the device locale/language to Japan & Russia
  • ensured that onboarding is still appearing when tapping on the omnibox after the Brave Widget onboarding appears
Japan Russia
Screenshot_20230301-134115 Screenshot_20230301-133942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove search engine onboarding for IN
4 participants