Skip to content

Remove search engine onboarding for IN #28656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deeppandya opened this issue Feb 21, 2023 · 2 comments · Fixed by brave/brave-core#17316
Closed

Remove search engine onboarding for IN #28656

deeppandya opened this issue Feb 21, 2023 · 2 comments · Fixed by brave/brave-core#17316
Assignees

Comments

@deeppandya
Copy link
Contributor

This is a follow up of : #27709.
we need to remove search engine onboarding for IN region as we have made Brave search as default for IN.

QA note : We need to make sure that tapping on search bar shouldn't show the search engine onboarding for the first time.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2023

@brave/qa-team can use brave/brave-core#17316 (comment) as an example of the cases/checks to run through as the issue is light on STR/Cases . The above requires 1.49.117 or higher for 1.49.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 7, 2023

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.49.118

Basically ensured that tapping on the URL bar on a clean install didn't launch the SE onboarding like we're currently doing with 1.48.x. Went through the following:

Test Case #1 - India

  • changed the device locale/language to India
  • installed/launched 1.49.118 Chromium: 111.0.5563.50
  • tapped on the URL and ensured that Brave Widgets was the first onboarding that appeared
  • ensured that tapping on the omnibox the second time around didn't launch the SE onboarding
  • ensured that there's no SE onboarding when tapping on the omnibox after several restarts
  • ensured that Brave was selected as the default SE for both Normal and Private windows/tabs
XRecorder_07032023_172742.mp4
Example Example Example Example
Screenshot_20230307-172609_Settings Screenshot_20230307-172554_Brave Screenshot_20230307-172528_Brave Screenshot_20230307-172542_Brave

Test Case #2 - Other Locales that have SE onboarding (Japan & Russua)

  • changed the device locale/language to Japan & Russia
  • ensured that onboarding is still appearing when tapping on the omnibox after the Brave Widget onboarding appears

Russia
Screenshot_20230307-165911_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants