Skip to content

Brave News sometimes picks the wrong language in the Subscribe Button #17046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2023

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Feb 5, 2023

Resolves brave/brave-browser#28064
Resolves brave/brave-browser#26092
Resolves brave/brave-browser#26307

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Navigate to https://brave.com/blog
  2. Click the subscribe button in the location bar.
  3. The feed should be "Brave Blog" not "Brave Blog Português"

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits! 👍

@fallaciousreasoning fallaciousreasoning merged commit 1add03b into master Feb 7, 2023
@fallaciousreasoning fallaciousreasoning deleted the bn-subscribe-lang branch February 7, 2023 01:48
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 7, 2023
fallaciousreasoning added a commit that referenced this pull request Mar 15, 2023
…#17046)

* Fix bug where first source was returned instead of the one in default locale

* Update JSON

* Add tests

* Remove string locale support (it isn't used)

* Changes for PR
kjozwiak pushed a commit that referenced this pull request Mar 20, 2023
…17633)

Brave News sometimes picks the wrong language in the Subscribe Button (#17046)

* Fix bug where first source was returned instead of the one in default locale

* Update JSON

* Add tests

* Remove string locale support (it isn't used)

* Changes for PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants