Skip to content

News Suggestions backend should remove www. prefix hack #26092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
petemill opened this issue Oct 18, 2022 · 1 comment · Fixed by brave/brave-core#17046
Closed

News Suggestions backend should remove www. prefix hack #26092

petemill opened this issue Oct 18, 2022 · 1 comment · Fixed by brave/brave-core#17046
Assignees
@fallaciousreasoning
Labels
feature/brave-news formerly brave-today OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Milestone
1.49.x - Release #3

Comments

@petemill
Copy link
Member

When https://github.com/brave/news-aggregator/issues/58 is solved, we should remove the www. prefix hack at https://github.com/brave/brave-core/blob/faf05930c46dd6b3fbe7f14e6e25f28bd88768a7/components/brave_today/browser/suggestions_controller.cc#L91
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". feature/brave-news formerly brave-today labels Oct 21, 2022
@fallaciousreasoning
Copy link

Issue is fixed in the aggregator - closing and removing.

@fallaciousreasoning fallaciousreasoning mentioned this issue Feb 5, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 7, 2023
@kjozwiak kjozwiak mentioned this issue Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
feature/brave-news formerly brave-today OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Projects
None yet
Milestone
1.49.x - Release #3
Development

Successfully merging a pull request may close this issue.

Brave News sometimes picks the wrong language in the Subscribe Button brave/brave-core
4 participants
@petemill @rebron @fallaciousreasoning @brave-builds