-
Notifications
You must be signed in to change notification settings - Fork 972
Don't block fingerprinting in extension pages #15931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
24e9c31
to
400fa28
Compare
7da2cec
to
ee13895
Compare
Verified with
Reproduced the issue in 1.45.127Reproduced the issue described in brave/brave-browser#26715 (comment) using 1.45.127
Part A of test plan - PASSEDVerified the test plan from brave/brave-browser#26715 (comment) - Part A: Using 1.47.90, verified both extensions listed in brave/brave-browser#26715 (comment) worked as described when
Part B of test plan - PASSEDVerified the test plan from brave/brave-browser#26715 (comment) - Part B: Using 1.47.90, run through the cases from brave/brave-browser#23170 (comment): Case 1: 1st launch, no Griffin -
|
step 3 |
step 7 |
step 9 |
---|---|---|
![]() |
![]() |
![]() |
Case 2: 2nd launch, Griffin-enabled study with Shields enabled- PASSED
(Continued from 1st launch, no Griffin
test, above)
10. restarted Brave
11. opened brave://version
12. confirmed in the case you get BraveScreenFingerprintingBlockerStudy:Enabled
(note, study is enabled at 100% on Nightly/Beta but only 50% on Release, so when testing on 1.45.x please be aware you may need a few attempts to get this study enabled)
13. loaded https://dev-pages.brave.software/fingerprinting/farbling.html
14. clicked on Generate fingerprints
16. loaded https://arthuredelstein.github.io/tracking_demos/screen.html
17. moved the mouse around and examined the tracked coordinates
Confirmed the values for This Page
were different from Local Frame
and Remote Frame
(which were both the same); the only four (4) trackable events were the mouseEvent.client(X/Y) coordinates
step 11 |
step 13 |
step 16 |
---|---|---|
![]() |
![]() |
![]() |
Case 3: 2nd launch, Griffin-enabled study with Shields disabled- PASSED
- continued from Case 2
- disable Shields in the Shields panel
- reload the https://dev-pages.brave.software/fingerprinting/farbling.html
- clicked on
Generate fingerprints
- loaded https://arthuredelstein.github.io/tracking_demos/screen.html
- disable Shields in the Shields panel
- moved the mouse around and examined the tracked coordinates
Confirmed all values were the same; no farbling was applied
brave://version |
shields down |
farbling.html |
screen.html |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 4: relaunch, default/no study - PASSED
(Continued from 1st launch, no Griffin
test, above)
10. restarted Brave
11. opened brave://version
12. confirmed in the case where BraveScreenFingerprintingBlockerStudy:Default
(note, study is enabled at 100% on Nightly/Beta but only 50% on Release - this means I had to disable brave://flags#brave-block-screen-fingerprinting
to test this on Nightly however when testing on Release 1.45.x please be aware you may need a few attempts to get this study as "Default".)
13. loaded https://dev-pages.brave.software/fingerprinting/farbling.html
14. clicked on Generate fingerprints
15. loaded https://arthuredelstein.github.io/tracking_demos/screen.html
16. moved the mouse around and examined the tracked coordinates
Confirmed there was no farbling of the screen/window coordinates shown in the screenshot
step 11 |
step 14 |
step 16 |
---|---|---|
![]() |
![]() |
![]() |
Resolves brave/brave-browser#26715
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: