-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Screen fingerprinting protection is applied to extensions pages #26715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@pes10k Do you have an opinion on the best approach here? The two options are:
|
Yep! I agree, option 1 seems A+ to me |
Reopening while we uplift |
QA testing ideasThe fix for this bug modifies our fingerprinting protections so they aren't applied to extensions pages. To test, we can check that (A) known broken extensions are no longer broken, while (B) fingerprinting protection still applies to http(s) pages. Part A
(Without this fix, the Login window does not open.)
(Without this fix, the popup appears but is much shorter.) Part B Confirm that screen fingerprinting is still working in http(s) pages by reproducing the tests done in #23170 (comment) |
Requires |
Verification PASSED on
Reproduced the issue in 1.45.127Reproduced the issue described in #26715 (comment) using 1.45.127
Part A of test plan - PASSEDVerified the test plan from #26715 (comment) - Part A: Using 1.45.131, verified both extensions listed in #26715 (comment) worked as described when
Part B of test plan - PASSEDVerified the test plan from #26715 (comment) - Part B: Using 1.45.131, run through the cases from #23170 (comment): Case 1: 1st launch, no Griffin -
|
step 3 |
step 7 |
step 9 |
---|---|---|
![]() |
![]() |
![]() |
Case 2: 2nd launch, Griffin-enabled study with Shields enabled- PASSED
(Continued from 1st launch, no Griffin
test, above)
10. restarted Brave
11. opened brave://version
12. confirmed in the case you get BraveScreenFingerprintingBlockerStudy:Enabled
(note, study is enabled at 100% on Nightly/Beta but only 50% on Release, so when testing on 1.45.x please be aware you may need a few attempts to get this study enabled)
13. loaded https://dev-pages.brave.software/fingerprinting/farbling.html
14. clicked on Generate fingerprints
16. loaded https://arthuredelstein.github.io/tracking_demos/screen.html
17. moved the mouse around and examined the tracked coordinates
Confirmed the values for This Page
were different from Local Frame
and Remote Frame
(which were both the same); the only four (4) trackable events were the mouseEvent.client(X/Y) coordinates
step 11 |
step 13 |
step 16 |
---|---|---|
![]() |
![]() |
![]() |
Case 3: 2nd launch, Griffin-enabled study with Shields disabled- PASSED
- continued from Case 2
- disable Shields in the Shields panel
- reload the https://dev-pages.brave.software/fingerprinting/farbling.html
- clicked on
Generate fingerprints
- loaded https://arthuredelstein.github.io/tracking_demos/screen.html
- disable Shields in the Shields panel
- moved the mouse around and examined the tracked coordinates
Confirmed all values were the same; no farbling was applied
brave://version |
shields down |
farbling.html |
screen.html |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Case 4: relaunch, default/no study - PASSED
(Continued from 1st launch, no Griffin
test, above)
10. restarted Brave
11. opened brave://version
12. confirmed in the case where BraveScreenFingerprintingBlockerStudy:Default
(note, study is enabled at 100% on Nightly/Beta but only 50% on Release - this means I had to disable brave://flags#brave-block-screen-fingerprinting
to test this on Nightly however when testing on Release 1.45.x please be aware you may need a few attempts to get this study as "Default".)
13. loaded https://dev-pages.brave.software/fingerprinting/farbling.html
14. clicked on Generate fingerprints
15. loaded https://arthuredelstein.github.io/tracking_demos/screen.html
16. moved the mouse around and examined the tracked coordinates
Confirmed there was no farbling of the screen/window coordinates shown in the screenshot
step 11 |
step 14 |
step 16 |
---|---|---|
![]() |
![]() |
![]() |
First reported here:
https://twitter.com/AaronToponce/status/1590038533963538432
I was able to confirm that the extension pop-up for Bitwarden is half size when screen fingerprinting protection is enabled. It appears this is because the browser is lying about the size of the screen to the popup page, which has a
chrome-extension://
address. We should not apply this protection to such extension pages.The text was updated successfully, but these errors were encountered: