Skip to content

Remove google translate install prompt #15093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 15, 2022

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Sep 14, 2022

Resolves brave/brave-browser#25347

  • Brave translate bubble/icon/extension install logic is removed;
  • Chromium icon/bubble are patched to change the icons => new UI is the same as have before
  • build-in translation is used for both enabled/disabled UseBraveTranslateGo feature.
  • Chromium Translate feature could be used to switch off translation completely;
  • UseBraveTranslateGo is removed from brave://flags and will be deleted in future PRs.

Bubble + icon (after/before):
image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m requested a review from a team as a code owner September 14, 2022 08:51
@atuchin-m atuchin-m self-assigned this Sep 14, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Sep 14, 2022
@@ -466,23 +466,6 @@ Or change later at <ph name="SETTINGS_EXTENIONS_LINK">$2<ex>brave://settings/ext
To disable this extension in private mode and Tor mode, unselect this option.
</message>

<!-- In-page Translation -->
<message name="IDS_BRAVE_TRANSLATE_BUBBLE_BEFORE_TRANSLATE_TITLE" desc="Title text for the translate bubble when asking to translate a page.">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This key is replaced to chromium IDS_BRAVE_TRANSLATE_BUBBLE_BEFORE_TRANSLATE_TITLE: Translate this page?
https://github.com/brave/brave-core/blob/master/app/generated_resources.grd#L9916

It's used only as the bubble title and invisible for UI (I believe it's used in accessibility mode)

@atuchin-m atuchin-m requested a review from a team as a code owner September 14, 2022 10:07
@iefremov iefremov self-requested a review September 14, 2022 13:20
@atuchin-m atuchin-m merged commit b09597c into master Sep 15, 2022
@atuchin-m atuchin-m deleted the remove-google-translate-install-prompt branch September 15, 2022 14:37
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code to suggest installing Google Translate Extension
2 participants