-
Notifications
You must be signed in to change notification settings - Fork 965
Remove google translate install prompt #15093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -466,23 +466,6 @@ Or change later at <ph name="SETTINGS_EXTENIONS_LINK">$2<ex>brave://settings/ext | |||
To disable this extension in private mode and Tor mode, unselect this option. | |||
</message> | |||
|
|||
<!-- In-page Translation --> | |||
<message name="IDS_BRAVE_TRANSLATE_BUBBLE_BEFORE_TRANSLATE_TITLE" desc="Title text for the translate bubble when asking to translate a page."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This key is replaced to chromium IDS_BRAVE_TRANSLATE_BUBBLE_BEFORE_TRANSLATE_TITLE
: Translate this page?
https://github.com/brave/brave-core/blob/master/app/generated_resources.grd#L9916
It's used only as the bubble title and invisible for UI (I believe it's used in accessibility mode)
Resolves brave/brave-browser#25347
UseBraveTranslateGo
feature.Translate
feature could be used to switch off translation completely;UseBraveTranslateGo
is removed from brave://flags and will be deleted in future PRs.Bubble + icon (after/before):

Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: