Skip to content

Remove code to suggest installing Google Translate Extension #25347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atuchin-m opened this issue Sep 12, 2022 · 5 comments · Fixed by brave/brave-core#15093
Closed

Remove code to suggest installing Google Translate Extension #25347

atuchin-m opened this issue Sep 12, 2022 · 5 comments · Fixed by brave/brave-core#15093

Comments

@atuchin-m
Copy link
Contributor

atuchin-m commented Sep 12, 2022

After enabling the new Translate feature by default we can remove the code to install Goggle Translate extension (including the bubble).

The behaviour for the existing Google Translate extension users is discussed in #24715

@atuchin-m
Copy link
Contributor Author

Test plan:

  1. Sanity check that build-in translation works (any desktop platform + android);
  2. Check that translation bubble and the icon in the omnibox is unchanged (any desktop platform);
  3. Check that Enable internal translate engine (brave-translate-go) flag is removed from brave://flags (desktop + android)

@stephendonner
Copy link

stephendonner commented Sep 27, 2022

Verified PASSED using

Brave 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (x86_64)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS macOS Version 11.7 (Build 20G817)

Case 1: in-build translation

example example
Screen Shot 2022-09-27 at 11 02 35 AM Screen Shot 2022-09-27 at 10 46 26 AM

Case 2: translation "bubble" and icon

Screen Shot 2022-09-27 at 10 54 13 AM

Case 3: confirmed that the brave-translate-go flag is removed from brave://flags

Screen Shot 2022-09-27 at 10 48 32 AM

Confirmed I was not prompted to install Google Translate, and Brave Translate worked without any additional setup

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.45.77 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 11 Version 21H2 (Build 22000.978)

Case 1: Verified Built-in translation works as expected and additionally not prompted to install Google Translate extension

Ex1 Ex2
image image

Case 2: Verified translation bubble and the icon in the omnibox displayed as expected

image

Case 3: Verified #brave-translate-go flag is removed from brave://flags

image

@btlechowski
Copy link

Verification passed on

Brave 1.45.90 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Ubuntu 18.04 LTS

Case 1: in-build translation

image
image

Case 2: translation "bubble" and icon

image

Case 3: confirmed that the brave-translate-go flag is removed from brave://flags

image

Confirmed I was not prompted to install Google Translate, and Brave Translate worked without any additional setup

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 20, 2022

Verification PASSED on vivo x70 Pro version 12 running Bravemonoarm64.apk_1.45.108

Case 1: in-build translation

Screenshot_20221020_192439

Case 2: translation "bubble" and icon

Example Example
Screenshot_20221020_192514 Screenshot_20221020_192522

Case 3: confirmed that the brave-translate-go flag is removed from brave://flags

Example Example
Screenshot_20221020_192736 Screenshot_20221020_192751

Confirmed I was not prompted to install Google Translate, and Brave Translate worked without any additional setup


Verification PASSED on Samsung Galaxy Tab A7 version 12 running Bravemonoarm64.apk_1.45.108

Case 1: in-build translation

Screenshot_20221020-193909_Brave

Case 2: translation "bubble" and icon

Example Example
Screenshot_20221020-193924_Brave Screenshot_20221020-193932_Brave

Case 3: confirmed that the brave-translate-go flag is removed from brave://flags

Screenshot_20221020-194020_Brave

Confirmed I was not prompted to install Google Translate, and Brave Translate worked without any additional setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment