-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove code to suggest installing Google Translate Extension #25347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Test plan:
|
Verified
|
Brave | 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (x86_64) |
---|---|
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580} |
OS | macOS Version 11.7 (Build 20G817) |
Case 1: in-build translation
Case 2: translation "bubble" and icon
Case 3: confirmed that the brave-translate-go
flag is removed from brave://flags
Confirmed I was not prompted to install Google Translate
, and Brave Translate worked without any additional setup
Verification passed on
Case 1: in-build translationCase 2: translation "bubble" and iconCase 3: confirmed that the
|
Verification PASSED on Case 1: in-build translationCase 2: translation "bubble" and iconCase 3: confirmed that the
|
After enabling the new Translate feature by default we can remove the code to install Goggle Translate extension (including the bubble).
The behaviour for the existing Google Translate extension users is discussed in #24715
The text was updated successfully, but these errors were encountered: