Skip to content

Enable Translate feature by default #25289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atuchin-m opened this issue Sep 8, 2022 · 7 comments · Fixed by brave/brave-core#15068
Closed

Enable Translate feature by default #25289

atuchin-m opened this issue Sep 8, 2022 · 7 comments · Fixed by brave/brave-core#15068

Comments

@atuchin-m
Copy link
Contributor

The feature is nearly to be rolled to 100% of users.
brave/brave-variations#355

The feature should be enabled by default in the code and the griffin experiment should be finished.

@LaurenWags
Copy link
Member

@atuchin-m could you provide a test plan for QA to use if manual QA is required here? if not, we should have this labeled as QA/No. Thanks!

@atuchin-m
Copy link
Contributor Author

@LaurenWags IMHO we need only sanity check that the feature is enabled despite the Griffin config.
brave/brave-core#15068 (comment)

@LaurenWags
Copy link
Member

LaurenWags commented Oct 7, 2022

@atuchin-m is the following sufficient?

  1. do a new profile (don't restart, so griffin isn't pulled)
  2. visit a site like interia.pl
  3. confirm we're offered Brave's Translation service not Google's

@atuchin-m
Copy link
Contributor Author

Yes, that's enough.

@LaurenWags
Copy link
Member

perfect, thanks for confirming @atuchin-m!

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Blocked labels Oct 7, 2022
@LaurenWags
Copy link
Member

Verified with

Brave | 1.45.90 Chromium: 106.0.5249.103 (Official Build) beta (x86_64)
-- | --
Revision | 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS | macOS Version 12.6 (Build 21G115)

Verified steps from #25289 (comment).

Confirmed on a clean profile (without restart, so no griffin seed pulled), that Brave's translate service was offered, not the Google extension:

Example Example Example
Screen Shot 2022-10-07 at 9 44 38 AM Screen Shot 2022-10-07 at 9 45 02 AM Screen Shot 2022-10-07 at 9 45 37 AM

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 7, 2022
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 19, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 19, 2022

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using the following build(s):

Brave	1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit) 
Revision	2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS	Android 12; Build/SP1A.210812.016
  • Confirmed Brave Translate is enabled by default on clean install
Wikipedia.fr Wikipedia.fr (Translated) Menu
screenshot-1666214290939 screenshot-1666214324379 screenshot-1666214339236
screenshot-1666215224268 screenshot-1666215235562 screenshot-1666215241683

@Uni-verse Uni-verse added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants