Skip to content

Farble Accept-Language header on subresources (uplift to 1.42.x) #14612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2022
Merged

Farble Accept-Language header on subresources (uplift to 1.42.x) #14612

merged 1 commit into from
Aug 17, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 12, 2022 •
edited by kjozwiak
Loading

Uplift of #14338
Resolves brave/brave-browser#24282

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner August 12, 2022 20:38
@brave-builds brave-builds self-assigned this Aug 12, 2022
@brave-builds brave-builds added this to the 1.42.x - Release #5 milestone Aug 12, 2022
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Aug 12, 2022
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.42.x approved 👍 QA has verified the PR on Nightly as per #14338 (comment).

@kjozwiak kjozwiak merged commit 43acf25 into 1.42.x Aug 17, 2022
@kjozwiak kjozwiak deleted the pr14338_mpilgrim_accept_language_subresources_1.42.x branch August 17, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.42.x - Release #5
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases