Skip to content

Reduce Language not farbling HTTP headers of subresources #24282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pilgrim-brave opened this issue Jul 26, 2022 · 5 comments · Fixed by brave/brave-core#14338
Closed

Reduce Language not farbling HTTP headers of subresources #24282

pilgrim-brave opened this issue Jul 26, 2022 · 5 comments · Fixed by brave/brave-core#14338
Assignees
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@pilgrim-brave
Copy link

Easily reproducible on the QA page, open devtools and network tab and refresh the page. The primary resource's Accept-Language request header is farbled, but subresources like site.css are not.

Screen Shot 2022-07-26 at 4 42 12 PM

Screen Shot 2022-07-26 at 4 42 26 PM

@kjozwiak
Copy link
Member

kjozwiak commented Aug 17, 2022

@brave/qa-team STR/Cases can be found via brave/brave-core#14338 (comment). Used the screenshot example that @pilgrim-brave provided via #24282 (comment) as guidance and received confirmation that the pass looks good 👍

@pilgrim-brave also recommended running through https://dev-pages.brave.software/fingerprinting/headers.html as well. Basically ensuring that Sub-resource has the correct values.

@LaurenWags
Copy link
Member

LaurenWags commented Aug 17, 2022

Verified with

Brave | 1.42.97 Chromium: 104.0.5112.102 (Official Build) (x86_64)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | macOS Version 12.5 (Build 21G72)

Reproduced the original issue mentioned via #24282 (comment) using the following STR/Cases:

  • installed 1.42.95 Chromium: 104.0.5112.81
  • restarted the browser and ensured that DisableReduceLanguage:Enabled
  • double checked and ensured that Prevent sites from fingerprinting me based on my language preferences was enabled via brave://settings/shields
  • added several languages via brave://settings/languages
  • visited https://dev-pages.brave.software/index.html and opened the DevTools
  • under the Network tab, clicked on Disable cache
  • refreshed https://dev-pages.brave.software/index.html once again
Farbled Not farbled Not farbled
2 3 4

Verified steps above using 1.42.97 Chromium: 104.0.5112.102:

Languages selected Farbled Farbled Farbled
2 3 4 5

Also ran through tests on https://dev-pages.brave.software/fingerprinting/headers.html as per #24282 (comment):

Languages Block Fingerprinting (Default) Aggressively Block Fingerprinting Allow Fingerprinting
2 2-block fp 3-aggressively block FP 4-allow FP

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 17, 2022

Verification PASSED on

Brave | 1.42.97 Chromium: 104.0.5112.102 (Official Build) (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 10 Version 21H2 (Build 19044.1889)

Reproduced the original issue mentioned via #24282 (comment) using the following STR/Cases:

  • installed 1.42.95 Chromium: 104.0.5112.81
  • restarted the browser and ensured that DisableReduceLanguage:Enabled
  • double checked and ensured that Prevent sites from fingerprinting me based on my language preferences was enabled via brave://settings/shields
  • added several languages via brave://settings/languages
  • visited https://dev-pages.brave.software/index.html and opened the DevTools
  • under the Network tab, clicked on Disable cache
  • refreshed https://dev-pages.brave.software/index.html once again
Farbled Not farbled Not farbled
image image image

Verified steps above using 1.42.97 Chromium: 104.0.5112.102:

Languages selected Farbled Farbled Farbled
image image image image

Also ran through tests on https://dev-pages.brave.software/fingerprinting/headers.html as per #24282 (comment):

Languages Block Fingerprinting (Default) Aggressively Block Fingerprinting Allow Fingerprinting
image image image image

@kjozwiak
Copy link
Member

Verification PASSED on Samsung Tablet S8 Ultra running Android 12 using the following build(s):

Brave | 1.42.97 Chromium: 104.0.5112.102 (Official Build) (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Android 12; Build/SP1A.210812.016
Languages Block Fingerprinting (Default) Aggressively Block Fingerprinting Allow Fingerprinting
Screenshot_20220817-124749_Settings Screenshot_20220817-124808_Brave Screenshot_20220817-124837_Brave Screenshot_20220817-124824_Brave

@kjozwiak
Copy link
Member

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.42.97 Chromium: 104.0.5112.102 (Official Build) (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Android 12; Build/SP1A.210812.016
Languages Block Fingerprinting (Default) Aggressively Block Fingerprinting Allow Fingerprinting
Screenshot_20220817-130446_Settings Screenshot_20220817-130511_Brave Screenshot_20220817-130534_Brave Screenshot_20220817-130522_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants