Skip to content

Fixes tipping when allow videos if off #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Fixes tipping when allow videos if off #1413

merged 1 commit into from
Jan 22, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 22, 2019

Resolves brave/brave-browser#2463

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • visit some youtube video
  • make sure that publisher is visible in the panel
  • make sure that is recorded in ac table
  • turn allow videos off
  • go to another youtube video
  • make sure that publisher is visible in the panel
  • make sure that is NOT recorded in ac table

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc added this to the 0.61.x - Nightly milestone Jan 22, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 22, 2019
@NejcZdovc NejcZdovc merged commit d29fcab into master Jan 22, 2019
@NejcZdovc NejcZdovc deleted the allow-videos branch January 22, 2019 19:13
NejcZdovc added a commit that referenced this pull request Jan 22, 2019
Fixes tipping when allow videos if off
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
referrer is updated in OnBeforeURLRequest_SiteHacksWork now
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
referrer is updated in OnBeforeURLRequest_SiteHacksWork now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow contributions to videos checkbox controls if you are able to tip a YouTube video
2 participants