Merge pull request #1413 from brave/allow-videos

NejcZdovc · web-flow · commit d29fcab47d6a · 2019-01-22T20:13:11.000+01:00
Fixes tipping when allow videos if off
diff --git a/vendor/bat-native-ledger/src/ledger_impl.cc b/vendor/bat-native-ledger/src/ledger_impl.cc
@@ -333,9 +333,12 @@ void LedgerImpl::SaveMediaVisit(const std::string& publisher_id,
                                 const ledger::VisitData& visit_data,
                                 const uint64_t& duration,
                                 const uint64_t window_id) {
-  if (bat_publishers_->getPublisherAllowVideos()) {
-    bat_publishers_->saveVisit(publisher_id, visit_data, duration, window_id);
+  uint64_t new_duration = duration;
+  if (!bat_publishers_->getPublisherAllowVideos()) {
+    new_duration = 0;
   }
+
+  bat_publishers_->saveVisit(publisher_id, visit_data, new_duration, window_id);
 }
 
 void LedgerImpl::SetPublisherExclude(const std::string& publisher_id, const ledger::PUBLISHER_EXCLUDE& exclude) {

Original file line number	Diff line number	Diff line change
`@@ -333,9 +333,12 @@ void LedgerImpl::SaveMediaVisit(const std::string& publisher_id,`
`333`	`333`	`const ledger::VisitData& visit_data,`
`334`	`334`	`const uint64_t& duration,`
`335`	`335`	`const uint64_t window_id) {`
`336`		`- if (bat_publishers_->getPublisherAllowVideos()) {`
`337`		`- bat_publishers_->saveVisit(publisher_id, visit_data, duration, window_id);`
	`336`	`+ uint64_t new_duration = duration;`
	`337`	`+ if (!bat_publishers_->getPublisherAllowVideos()) {`
	`338`	`+ new_duration = 0;`
`338`	`339`	`}`
	`340`	`+`
	`341`	`+ bat_publishers_->saveVisit(publisher_id, visit_data, new_duration, window_id);`
`339`	`342`	`}`
`340`	`343`
`341`	`344`	`void LedgerImpl::SetPublisherExclude(const std::string& publisher_id, const ledger::PUBLISHER_EXCLUDE& exclude) {`