Skip to content

Use grit generator properly to generate non-overlapped resource IDs. (uplift to 1.39.x) #13342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2022
Merged

Use grit generator properly to generate non-overlapped resource IDs. (uplift to 1.39.x) #13342

merged 1 commit into from
May 17, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 16, 2022 •
edited by kjozwiak
Loading

Uplift of #13335
Resolves brave/brave-browser#22849

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner May 16, 2022 16:58
@brave-builds brave-builds requested review from bsclifton, emerick and a team and removed request for a team May 16, 2022 16:58
@brave-builds brave-builds self-assigned this May 16, 2022
@brave-builds brave-builds added this to the 1.39.x - Beta milestone May 16, 2022
kjozwiak
kjozwiak approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.39.x approved 👍

@kjozwiak kjozwiak merged commit 9e9b663 into 1.39.x May 17, 2022
@kjozwiak kjozwiak deleted the pr13335_fix-brave-resource-ids_1.39.x branch May 17, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton bsclifton is a code owner automatically assigned from brave/rewards-client

@emerick emerick Awaiting requested review from emerick emerick is a code owner automatically assigned from brave/rewards-client

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases