Skip to content

Generated resource IDs may be overlapped because of misused resource_ids file #22849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
goodov opened this issue May 13, 2022 · 0 comments · Fixed by brave/brave-core#13335
Closed

Generated resource IDs may be overlapped because of misused resource_ids file #22849

goodov opened this issue May 13, 2022 · 0 comments · Fixed by brave/brave-core#13335
Assignees
@goodov
Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Milestone
1.39.x - Release

Comments

@goodov
Copy link
Member

goodov commented May 13, 2022 •
edited
Loading

resource_ids should be used only as a guide for the actual IDs generation. It should be passed through grit.py script to get a real ids file which will count the amount of resources and will ensure no overlaps are present.

see also https://bravesoftware.slack.com/archives/C7VLGSR55/p1652297282410429
@goodov goodov self-assigned this May 13, 2022
@goodov goodov mentioned this issue May 13, 2022
Merged
25 tasks
@brave-builds brave-builds mentioned this issue May 16, 2022
Merged
7 tasks
@goodov goodov added this to the 1.40.x - Nightly milestone May 16, 2022
This was referenced Apr 12, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goodov goodov

Labels
dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging a pull request may close this issue.

Use grit generator properly to generate non-overlapped resource IDs. brave/brave-core
2 participants
@kjozwiak @goodov